Bug 59205 - Make it harder to use HandleSlot incorrectly
Summary: Make it harder to use HandleSlot incorrectly
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Oliver Hunt
Depends on: 59217 59218
  Show dependency treegraph
Reported: 2011-04-22 09:41 PDT by Oliver Hunt
Modified: 2011-04-22 12:11 PDT (History)
4 users (show)

See Also:

Patch (18.17 KB, patch)
2011-04-22 11:03 PDT, Oliver Hunt
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2011-04-22 09:41:11 PDT
Make it harder to use HandleSlot incorrectly
Comment 1 Oliver Hunt 2011-04-22 11:03:36 PDT
Created attachment 90726 [details]
Comment 2 Geoffrey Garen 2011-04-22 11:17:18 PDT
Comment on attachment 90726 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=90726&action=review


> Source/JavaScriptCore/runtime/WriteBarrier.h:47
> +    JSValue* toJSValueRef() { return this; }

This name was a bit confusing to me because "JSValueRef" is a name in the JavaScriptCore API.

I'd recommend just having toJSValue(), and using &toJSValue() where needed.
Comment 3 Oliver Hunt 2011-04-22 11:28:20 PDT
Committed r84650: <http://trac.webkit.org/changeset/84650>
Comment 4 Build Bot 2011-04-22 11:29:20 PDT
Attachment 90726 [details] did not build on win:
Build output: http://queues.webkit.org/results/8498391
Comment 5 WebKit Review Bot 2011-04-22 11:47:45 PDT
http://trac.webkit.org/changeset/84650 might have broken Windows Release (Build) and Windows Debug (Build)