Bug 59191 - Web Inspector: js formatter should never insert new tokens or remove existing tokens and comments.
Summary: Web Inspector: js formatter should never insert new tokens or remove existing...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-22 04:56 PDT by Pavel Podivilov
Modified: 2011-04-22 06:46 PDT (History)
13 users (show)

See Also:

Attachments
New JavaScript formatter based on UglifyJS tokenizer. (104.79 KB, patch)
2011-04-22 05:03 PDT, Pavel Podivilov 		pfeldman: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-04-22 04:56:45 PDT 
Web Inspector: js formatter should never insert new tokens or remove existing tokens and comments.
Comment 1 Pavel Podivilov 2011-04-22 05:03:26 PDT 
Created attachment 90693 [details]
New JavaScript formatter based on UglifyJS tokenizer.
Comment 2 Pavel Feldman 2011-04-22 05:24:07 PDT 
Comment on attachment 90693 [details]
New JavaScript formatter based on UglifyJS tokenizer.

View in context: https://bugs.webkit.org/attachment.cgi?id=90693&action=review

> Source/WebCore/WebCore.vcproj/WebCore.vcproj:67476
> +					RelativePath="..\inspector\front-end\UglifyJS\JavaScriptFormatter.js"

Is this formatter a part of the Uglify package? If not, it should be stored outside the folder.
Comment 3 Pavel Podivilov 2011-04-22 05:35:41 PDT 
Committed r84620: <http://trac.webkit.org/changeset/84620>
Comment 4 WebKit Review Bot 2011-04-22 06:46:03 PDT 
http://trac.webkit.org/changeset/84620 might have broken GTK Linux 32-bit Release
The following tests are not passing:
media/controls-strict.html