RESOLVED FIXED 59191
Web Inspector: js formatter should never insert new tokens or remove existing tokens and comments. 
https://bugs.webkit.org/show_bug.cgi?id=59191
Summary Web Inspector: js formatter should never insert new tokens or remove existing...
Pavel Podivilov
Reported Friday, April 22, 2011 12:56:45 PM UTC
Web Inspector: js formatter should never insert new tokens or remove existing tokens and comments.
Attachments
New JavaScript formatter based on UglifyJS tokenizer. (104.79 KB, patch)
2011-04-22 05:03 PDT, Pavel Podivilov 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 Friday, April 22, 2011 1:03:26 PM UTC
Created attachment 90693 [details] New JavaScript formatter based on UglifyJS tokenizer.
Pavel Feldman
Comment 2 Friday, April 22, 2011 1:24:07 PM UTC
Comment on attachment 90693 [details] New JavaScript formatter based on UglifyJS tokenizer. View in context: https://bugs.webkit.org/attachment.cgi?id=90693&action=review > Source/WebCore/WebCore.vcproj/WebCore.vcproj:67476 > + RelativePath="..\inspector\front-end\UglifyJS\JavaScriptFormatter.js" Is this formatter a part of the Uglify package? If not, it should be stored outside the folder.
Pavel Podivilov
Comment 3 Friday, April 22, 2011 1:35:41 PM UTC
Committed r84620: <http://trac.webkit.org/changeset/84620>
WebKit Review Bot
Comment 4 Friday, April 22, 2011 2:46:03 PM UTC
http://trac.webkit.org/changeset/84620 might have broken GTK Linux 32-bit Release The following tests are not passing: media/controls-strict.html
Note You need to log in before you can comment on or make changes to this bug.