RESOLVED FIXED Bug 59184
[Gtk] Implement LayoutTestController::setPluginsEnabled 
https://bugs.webkit.org/show_bug.cgi?id=59184
Summary [Gtk] Implement LayoutTestController::setPluginsEnabled
Alexandre Mazari
Reported 2011-04-22 02:19:15 PDT
[Gtk] Implement LayoutTestController::setPluginsEnabled
Attachments
Patch (1.43 KB, patch)
2011-04-22 02:20 PDT, Alexandre Mazari 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexandre Mazari
Comment 1 2011-04-22 02:20:02 PDT
Created attachment 90681 [details] Patch
Martin Robinson
Comment 2 2011-04-23 19:44:33 PDT
Comment on attachment 90681 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90681&action=review Can we unskip any tests with this patch? > Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:550 > + WebKitWebSettings* settings = webkit_web_view_get_settings(view); > + g_object_set(G_OBJECT(settings), "enable-plugins", flag, NULL); This can just be: g_object_set(G_OBJECT(webkit_web_view_get_settings(view)), "enable-plugins", flag, NULL);
Xan Lopez
Comment 3 2011-04-26 15:41:17 PDT
Comment on attachment 90681 [details] Patch Hopefully this should unskip some tests, but the patch looks good.
Martin Robinson
Comment 4 2011-04-26 15:51:05 PDT
Alexandre, please take another pass when this lands which unskips tests which use this feature. If they cannot be unskipped please open bugs for them. Thank you!
WebKit Commit Bot
Comment 5 2011-04-26 17:04:04 PDT
The commit-queue encountered the following flaky tests while processing attachment 90681 [details]: http/tests/xmlhttprequest/cross-origin-authorization.html bug 52398 (author: ap@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2011-04-26 17:05:34 PDT
Comment on attachment 90681 [details] Patch Clearing flags on attachment: 90681 Committed r84985: <http://trac.webkit.org/changeset/84985>
WebKit Commit Bot
Comment 7 2011-04-26 17:05:39 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 8 2011-04-26 18:08:13 PDT
http://trac.webkit.org/changeset/84985 might have broken Windows 7 Release (Tests) The following tests are not passing: fast/blockflow/Kusa-Makura-background-canvas.html fast/blockflow/border-vertical-lr.html fast/blockflow/fallback-orientation.html fast/blockflow/japanese-lr-selection.html fast/blockflow/japanese-lr-text.html fast/blockflow/japanese-rl-selection.html fast/blockflow/japanese-rl-text.html fast/blockflow/japanese-ruby-vertical-lr.html fast/blockflow/japanese-ruby-vertical-rl.html fast/dynamic/text-combine.html fast/repaint/japanese-rl-selection-clear.html fast/repaint/japanese-rl-selection-repaint.html fast/ruby/base-shorter-than-text.html fast/text/emphasis-vertical.html fast/text/international/text-combine-image-test.html fast/text/international/vertical-text-glyph-test.html fast/text/justify-ideograph-vertical.html
Note You need to log in before you can comment on or make changes to this bug.