Bug 59171 - [Qt][WK2] Implement DrawingAreaImpl for Qt.
Summary: [Qt][WK2] Implement DrawingAreaImpl for Qt.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-04-21 20:34 PDT by Andreas Kling
Modified: 2011-04-22 02:44 PDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (20.14 KB, patch)
2011-04-21 20:36 PDT, Andreas Kling 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-04-21 20:34:41 PDT 
Now that it's open for business, we should implement DrawingAreaImpl for the Qt port of WebKit2.
Comment 1 Andreas Kling 2011-04-21 20:36:02 PDT 
Created attachment 90662 [details]
Proposed patch
Comment 2 WebKit Review Bot 2011-04-21 20:38:28 PDT 
Attachment 90662 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/UIProcess/qt/BackingStoreQt.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2011-04-21 22:14:07 PDT 
Comment on attachment 90662 [details]
Proposed patch

Woo. r=me.
Comment 4 Andreas Kling 2011-04-22 02:44:21 PDT 
Committed r84613: <http://trac.webkit.org/changeset/84613>