Bug 59170 - Remove remaining uses of deprecated version of toJS
Summary: Remove remaining uses of deprecated version of toJS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-21 20:18 PDT by Sam Weinig
Modified: 2011-04-22 11:24 PDT (History)
7 users (show)

See Also:

Attachments
Patch (25.67 KB, patch)
2011-04-21 20:25 PDT, Sam Weinig 		barraclough: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-04-21 20:18:40 PDT 
Remove remaining uses of deprecated version of toJS
Comment 1 Sam Weinig 2011-04-21 20:25:11 PDT 
Created attachment 90661 [details]
Patch
Comment 2 Early Warning System Bot 2011-04-21 20:38:34 PDT 
Attachment 90661 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8496228
Comment 3 Collabora GTK+ EWS bot 2011-04-22 01:43:04 PDT 
Attachment 90661 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/8494369
Comment 4 Sam Weinig 2011-04-22 10:37:28 PDT 
Committed r84641: <http://trac.webkit.org/changeset/84641>
Comment 5 WebKit Review Bot 2011-04-22 10:45:41 PDT 
http://trac.webkit.org/changeset/84641 might have broken Qt Linux Release minimal
Comment 6 Eric Seidel (no email) 2011-04-22 11:21:38 PDT 
Comment on attachment 90661 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90661&action=review

> LayoutTests/ChangeLog:10
> +        failures are pure JS objects (Array, Boolean, String, Number, Function).

I think these aren't failures, and the test shoudl be updated.  Ask abarth.  But I think I was wrong when I wrote this test.  I think pure JS types always use the dynamic global object per the spec.
Comment 7 Adam Barth 2011-04-22 11:24:10 PDT 
Comment on attachment 90661 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90661&action=review

>> LayoutTests/ChangeLog:10
>> +        * fast/dom/prototype-inheritance-2-expected.txt:
>> +        Add new passing results since we now use the correct global object. The remaining
>> +        failures are pure JS objects (Array, Boolean, String, Number, Function).
> 
> I think these aren't failures, and the test shoudl be updated.  Ask abarth.  But I think I was wrong when I wrote this test.  I think pure JS types always use the dynamic global object per the spec.

They always use the lexical global object, but, yeah, the test isn't correct for these primitive types.