Bug 59169 - Minimize synchronous calls during loading
Summary: Minimize synchronous calls during loading
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.6
: P2 Normal
Assignee: Alexey Proskuryakov
Depends on:
Reported: 2011-04-21 20:18 PDT by Alexey Proskuryakov
Modified: 2011-04-21 21:26 PDT (History)
2 users (show)

See Also:

proposed patch (1.69 KB, patch)
2011-04-21 20:22 PDT, Alexey Proskuryakov
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2011-04-21 20:18:21 PDT
r84526 added synchronous calls to web process to discard marked text when selection changes. The code was structured so that the same call was made when navigating to a new page, which is obviously unnecessary, as everything in Editor best reset anyway.

Unfortunately, CoreIPC delivers sync and async calls out of order while serving a sync call in other direction, causing havoc, freezes and crashes as the UI process got confused about web process state. So, we should minimize sync calls, especially when we know that something else is happening in the web process.
Comment 1 Alexey Proskuryakov 2011-04-21 20:22:30 PDT
Created attachment 90659 [details]
proposed patch
Comment 2 Alexey Proskuryakov 2011-04-21 21:26:45 PDT
Committed <http://trac.webkit.org/changeset/84598>.