RESOLVED FIXED Bug 59164
Object.create creates uncachable objects 
https://bugs.webkit.org/show_bug.cgi?id=59164
Summary Object.create creates uncachable objects
Oliver Hunt
Reported 2011-04-21 18:05:18 PDT
Object.create creates uncachable objects
Attachments
Patch (1.82 KB, patch)
2011-04-21 18:06 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (4.86 KB, patch)
2011-04-22 14:05 PDT, Oliver Hunt 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2011-04-21 18:06:45 PDT
Created attachment 90645 [details] Patch
Geoffrey Garen
Comment 2 2011-04-21 18:24:59 PDT
Comment on attachment 90645 [details] Patch r=me
Oliver Hunt
Comment 3 2011-04-21 18:32:54 PDT
Committed r84583: <http://trac.webkit.org/changeset/84583>
WebKit Review Bot
Comment 4 2011-04-21 19:16:26 PDT
http://trac.webkit.org/changeset/84583 might have broken Qt Linux Release The following tests are not passing: fast/js/Object-create.html
Geoffrey Garen
Comment 5 2011-04-21 19:16:55 PDT
Broke a test: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Debug/r84585%20(21737)/fast/js/Object-create-pretty-diff.html FAIL Object.getPrototypeOf(Object.create(null)) should be null. Was [object Object]. You changed to unconditionally use an empty object prototype, even if null is passed in.
Geoffrey Garen
Comment 6 2011-04-22 11:05:13 PDT
BTW, I think the right way to fix this is to give JSGlobalObject (or maybe JSGlobalData) a nullPrototypeStructure, just like the emptyObjectStructure. That way, Object.create will be correct for null prototypes, and still efficient.
Oliver Hunt
Comment 7 2011-04-22 14:05:33 PDT
Created attachment 90757 [details] Patch
Geoffrey Garen
Comment 8 2011-04-22 14:08:08 PDT
Comment on attachment 90757 [details] Patch r=me
WebKit Review Bot
Comment 9 2011-04-22 16:18:43 PDT
http://trac.webkit.org/changeset/84679 might have broken GTK Linux 64-bit Debug
Oliver Hunt
Comment 10 2011-04-22 18:16:40 PDT
Committed r84679: <http://trac.webkit.org/changeset/84679>
Note You need to log in before you can comment on or make changes to this bug.