Bug 59142 - Add more test coverage to fast/url
Summary: Add more test coverage to fast/url
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL: http://www.lookout.net
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-21 14:54 PDT by Chris Weber
Modified: 2011-04-22 00:31 PDT (History)
4 users (show)

See Also:


Attachments
A patch adding new test cases to the fast/url test suite (9.63 KB, patch)
2011-04-21 14:54 PDT, Chris Weber
no flags Details | Formatted Diff | Diff
Patch (23.11 KB, patch)
2011-04-21 16:10 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (35.55 KB, patch)
2011-04-21 16:48 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Weber 2011-04-21 14:54:20 PDT
Created attachment 90609 [details]
A patch adding new test cases to the fast/url test suite

Adam Barth asked the public IRI mailing list for more test cases in this suite. 

- Added new test cases for IDNA2003
- Added new test cases for IDNA2008
- Augmented test cases for port.js, host.js, and path.js
Comment 1 Adam Barth 2011-04-21 14:56:35 PDT
Thanks.  This patch isn't quite formated the way we like.  I'll reformat it for you.
Comment 2 Adam Barth 2011-04-21 14:58:47 PDT
In the future, you can upload patches for review by running the following script:

./Tools/Script/webkit-patch upload

(You can also supply the bug number if you want to upload your patch to an existing bug.)  That script will generated a ChangeLog entry for you and ask you to fill it out with a description of your patch.  The script will also take care of making sure the patch is based in the root directory of the repository.
Comment 3 Adam Barth 2011-04-21 16:10:39 PDT
Created attachment 90624 [details]
Patch
Comment 4 Adam Barth 2011-04-21 16:48:00 PDT
Created attachment 90633 [details]
Patch
Comment 5 WebKit Commit Bot 2011-04-21 23:44:16 PDT
The commit-queue encountered the following flaky tests while processing attachment 90633 [details]:

http/tests/xmlhttprequest/basic-auth.html bug 51613 (author: ap@webkit.org)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2011-04-21 23:46:29 PDT
Comment on attachment 90633 [details]
Patch

Clearing flags on attachment: 90633

Committed r84606: <http://trac.webkit.org/changeset/84606>
Comment 7 WebKit Commit Bot 2011-04-21 23:46:35 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 WebKit Review Bot 2011-04-22 00:31:24 PDT
http://trac.webkit.org/changeset/84606 might have broken Qt Linux Release
The following tests are not passing:
fast/url/idna2003.html
fast/url/idna2008.html
fast/url/path.html