WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
59140
WebKit is erroneously modifying the DOM; adding 'aria-selected' to tables
https://bugs.webkit.org/show_bug.cgi?id=59140
Summary
WebKit is erroneously modifying the DOM; adding 'aria-selected' to tables
chris fleizach
Reported
2011-04-21 14:24:54 PDT
WebKit is calling setAttribute('aria-selected', 'true') on each row. Notice the second table turns completely purple as the VO cursor goes through each row. Even if WebKit were cleaning up after itself, it should not be modifying the DOM at all.
Attachments
patch
(6.60 KB, patch)
2011-04-21 17:34 PDT
,
chris fleizach
bdakin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
chris fleizach
Comment 1
2011-04-21 14:25:10 PDT
rdar://9275872
chris fleizach
Comment 2
2011-04-21 17:34:02 PDT
Created
attachment 90641
[details]
patch
WebKit Review Bot
Comment 3
2011-04-21 17:36:21 PDT
Attachment 90641
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/acce..." exit_code: 1 Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1639: Should only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2240: Should only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Beth Dakin
Comment 4
2011-04-21 17:56:22 PDT
Comment on
attachment 90641
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=90641&action=review
> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1641 >
Is there any reason to leave this empty function around? It seems like we should just get rid of it.
> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2242 >
Same here.
chris fleizach
Comment 5
2011-04-21 17:57:49 PDT
(In reply to
comment #4
)
> (From update of
attachment 90641
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=90641&action=review
> > > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1641 > > > > Is there any reason to leave this empty function around? It seems like we should just get rid of it. > > > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2242 > > > > Same here.
I think eventually we want to put something there, but agreed, for now we should just remove
Beth Dakin
Comment 6
2011-04-21 18:26:05 PDT
Comment on
attachment 90641
[details]
patch r=me, but I would prefer for those functions to be removed for now.
chris fleizach
Comment 7
2011-04-21 18:28:35 PDT
(In reply to
comment #6
)
> (From update of
attachment 90641
[details]
) > r=me, but I would prefer for those functions to be removed for now.
thanks. will remove
chris fleizach
Comment 8
2011-04-21 22:02:01 PDT
http://trac.webkit.org/changeset/84600
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug