Bug 59140 – WebKit is erroneously modifying the DOM; adding 'aria-selected' to tables

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

WebKit is calling setAttribute('aria-selected', 'true') on each row. Notice the second table turns completely purple as the VO cursor goes through each row. Even if WebKit were cleaning up after itself, it should not be modifying the DOM at all.

[chris fleizach]

rdar://9275872

[chris fleizach]

Created attachment 90641 [details]
patch

[WebKit Review Bot]

Attachment 90641 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/acce..." exit_code: 1

Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1639:  Should only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2240:  Should only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Beth Dakin]

Comment on attachment 90641 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90641&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1641
>  

Is there any reason to leave this empty function around? It seems like we should just get rid of it.

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2242
>  

Same here.

[chris fleizach]

(In reply to comment #4)
> (From update of attachment 90641 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=90641&action=review
> 
> > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1641
> >  
> 
> Is there any reason to leave this empty function around? It seems like we should just get rid of it.
> 
> > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2242
> >  
> 
> Same here.

I think eventually we want to put something there, but agreed, for now we should just remove

[Beth Dakin]

Comment on attachment 90641 [details]
patch

r=me, but I would prefer for those functions to be removed for now.

[chris fleizach]

(In reply to comment #6)
> (From update of attachment 90641 [details])
> r=me, but I would prefer for those functions to be removed for now.

thanks. will remove

[chris fleizach]

http://trac.webkit.org/changeset/84600