WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
59112
[chromium] Don't upload partially drawn tiles in the compositor
https://bugs.webkit.org/show_bug.cgi?id=59112
Summary
[chromium] Don't upload partially drawn tiles in the compositor
Adrienne Walker
Reported
2011-04-21 10:22:35 PDT
[chromium] Don't upload partially drawn tiles in the compositor
Attachments
Patch
(5.43 KB, patch)
2011-04-21 10:53 PDT
,
Adrienne Walker
jamesr
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adrienne Walker
Comment 1
2011-04-21 10:53:45 PDT
Created
attachment 90557
[details]
Patch
Adrienne Walker
Comment 2
2011-04-21 11:11:41 PDT
This corresponds to
http://crbug.com/79960
. What was happening is this convoluted chain of events: Content layer passes some update rect to update. Update function finds all the tiles that intersect that rect. Paint rect is calculated from the union of the dirty rects of those tiles. Upload function finds all the tiles that intersects with that paint rect. Because of tile border texels, the set of tiles intersecting the paint rect is larger than that of the set of tiles intersecting the update rect. One of these tiles that was not in the update rect but in the paint rect only partially intersects the paint rect. Part of the tile is uploaded even though more of it is dirty. The tile's dirty rect is cleared even though only part of the tile has been uploaded. The tile has been partially modified, so it looks wrong. The real problem is that we're trying to upload data for tiles that we didn't intend to update. If we had intended to upload data for them, we would have painted their entire dirty rect. So the simplest fix is to iterate over the same set of tiles in both update and upload.
James Robinson
Comment 3
2011-04-21 11:39:38 PDT
Comment on
attachment 90557
[details]
Patch Bleh
Adrienne Walker
Comment 4
2011-04-21 13:19:48 PDT
Committed
r84542
: <
http://trac.webkit.org/changeset/84542
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug