Bug 59111 - WebKit2: Secure text input is not enabled when going back to a cached page
Summary: WebKit2: Secure text input is not enabled when going back to a cached page
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.6
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-04-21 10:12 PDT by Alexey Proskuryakov
Modified: 2020-05-27 13:43 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2011-04-21 10:12:06 PDT
Steps to reproduce:
1. Open Keyboard Viewer from under a flag menu (enable it in International preferences if needed).
2. Open data:text/html,<input type=password>
3. Type something in the password input field. Observe that your typing isn't reflected in Keyboard Viewer.
4. Open data:text/html,<input> in the same tab.
5. Type something in the input, observe that typing is now reflected in Keyboard Viewer.
6. Click browser Back button.
7. Type something in the password input field.

Results: typing is visible in the Keyboard Viewer, although it obviously shouldn't.

This happens because we're setting up secure event mode in a respondToChangedSelection() when the password field is focused - but didCommitLoad is sent after a cached frame is fully restored, and we then reset it to "new page" state.

It's not easy to say when didCommitLoad should really be sent for cached page loads, but I think that doing it after a complete restore is definitely wrong.
Comment 1 Alexey Proskuryakov 2011-04-21 15:22:25 PDT
<rdar://problem/9320465>