Bug 59105 - Web Inspector: fix calls to WebInspector.ObjectPropertiesSection constructor
Summary: Web Inspector: fix calls to WebInspector.ObjectPropertiesSection constructor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-21 08:24 PDT by Andrey Kosyakov
Modified: 2011-04-21 09:57 PDT (History)
9 users (show)

See Also:

Attachments
patch (4.01 KB, patch)
2011-04-21 09:05 PDT, Andrey Kosyakov 		pfeldman: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2011-04-21 08:24:00 PDT 
Many calls to WebInspector.ObjectPropertiesSection() are missing one of the arguments (apparently, empty placeholder).
This results in "true" being shown for objects with no properties (i.e. in case when object's __proto__ === null).
Comment 1 Andrey Kosyakov 2011-04-21 09:05:18 PDT 
Created attachment 90544 [details]
patch
Comment 2 Pavel Feldman 2011-04-21 09:08:52 PDT 
Comment on attachment 90544 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90544&action=review

> Source/WebCore/inspector/front-end/ConsoleView.js:600
> +        elem.appendChild(new WebInspector.ObjectPropertiesSection(obj, obj.description, null, null, false).element);

Just trim the call site here and in all changes below.
Comment 3 Andrey Kosyakov 2011-04-21 09:57:27 PDT 
Manually committed r84510: http://trac.webkit.org/changeset/84510