WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 59105
Web Inspector: fix calls to WebInspector.ObjectPropertiesSection constructor
https://bugs.webkit.org/show_bug.cgi?id=59105
Summary
Web Inspector: fix calls to WebInspector.ObjectPropertiesSection constructor
Andrey Kosyakov
Reported
2011-04-21 08:24:00 PDT
Many calls to WebInspector.ObjectPropertiesSection() are missing one of the arguments (apparently, empty placeholder). This results in "true" being shown for objects with no properties (i.e. in case when object's __proto__ === null).
Attachments
patch
(4.01 KB, patch)
2011-04-21 09:05 PDT
,
Andrey Kosyakov
pfeldman
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Andrey Kosyakov
Comment 1
2011-04-21 09:05:18 PDT
Created
attachment 90544
[details]
patch
Pavel Feldman
Comment 2
2011-04-21 09:08:52 PDT
Comment on
attachment 90544
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=90544&action=review
> Source/WebCore/inspector/front-end/ConsoleView.js:600 > + elem.appendChild(new WebInspector.ObjectPropertiesSection(obj, obj.description, null, null, false).element);
Just trim the call site here and in all changes below.
Andrey Kosyakov
Comment 3
2011-04-21 09:57:27 PDT
Manually committed
r84510
:
http://trac.webkit.org/changeset/84510
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug