Bug 59096 – Split GlyphPage from GlyphPageTreeNode.h into its own header

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Nikolas Zimmermann]

Split GlyphPage from GlyphPageTreeNode.h into its own header

[Nikolas Zimmermann]

Created attachment 90522 [details]
Patch

[Dirk Schulze]

Comment on attachment 90522 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90522&action=review

r=me

> Source/WebCore/platform/graphics/GlyphPage.h:77
> +    static const size_t size = 256; // Covers Latin-1 in a single page.

Can you move this to the top of the file and give it a more meaningful name? Not sure if you have to add a g or k for static consts.

> Source/WebCore/platform/graphics/GlyphPage.h:141
> +    // Separate arrays, rather than array of GlyphData, to save space.

Not sure what you mean here. Can you rephrase it

[Nikolas Zimmermann]

(In reply to comment #2)
> (From update of attachment 90522 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=90522&action=review
> 
> r=me
> 
> > Source/WebCore/platform/graphics/GlyphPage.h:77
> > +    static const size_t size = 256; // Covers Latin-1 in a single page.
> 
> Can you move this to the top of the file and give it a more meaningful name? Not sure if you have to add a g or k for static consts.
> 
> > Source/WebCore/platform/graphics/GlyphPage.h:141
> > +    // Separate arrays, rather than array of GlyphData, to save space.
> 
> Not sure what you mean here. Can you rephrase it

As discussed on IRC, that requires to change dozens of files, the intent of this patch is only to refactor, not to change any code.

[Nikolas Zimmermann]

Landed in r84490.