Bug 59091 - [EFL] Remove ewk_eapi.h
Summary: [EFL] Remove ewk_eapi.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-21 05:58 PDT by Ryuan Choi
Modified: 2011-04-25 11:07 PDT (History)
9 users (show)

See Also:

Attachments
Patch (6.87 KB, patch)
2011-04-21 06:03 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2011-04-21 05:58:40 PDT 
IMO, ewk_eapi.h is just for EAPI macro provided by Eina.
Comment 1 Ryuan Choi 2011-04-21 06:03:03 PDT 
Created attachment 90518 [details]
Patch
Comment 2 Gyuyoung Kim 2011-04-21 17:16:05 PDT 
LGTM. BTW, if we want to change EAPI visibility, how to change it ? And also, if we want to define additional macro to adjust ewk files, is it good to keep the file ?
Comment 3 Ryuan Choi 2011-04-21 18:19:14 PDT 
(In reply to comment #2)
> LGTM. BTW, if we want to change EAPI visibility, how to change it ? And also, if we want to define additional macro to adjust ewk files, is it good to keep the file ?

Does we need to change visibility?
Although we need, it will not work well because Eina.h will redefine EAPI.

About other macro,
we can make better one at that time if needed.
ewk_eapi.h looks just for eapi.
Comment 4 Gyuyoung Kim 2011-04-21 18:39:33 PDT 
(In reply to comment #3)
> (In reply to comment #2)
> > LGTM. BTW, if we want to change EAPI visibility, how to change it ? And also, if we want to define additional macro to adjust ewk files, is it good to keep the file ?
> 
> Does we need to change visibility?
> Although we need, it will not work well because Eina.h will redefine EAPI.
> 
> About other macro,
> we can make better one at that time if needed.
> ewk_eapi.h looks just for eapi.

OK, LGTM.
Comment 5 WebKit Commit Bot 2011-04-25 04:18:15 PDT 
Comment on attachment 90518 [details]
Patch

Clearing flags on attachment: 90518

Committed r84771: <http://trac.webkit.org/changeset/84771>
Comment 6 WebKit Commit Bot 2011-04-25 04:18:20 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Review Bot 2011-04-25 11:07:16 PDT 
http://trac.webkit.org/changeset/84771 might have broken SnowLeopard Intel Release (WebKit2 Tests)