RESOLVED FIXED 59087
Centralize typedef unsigned short Glyph in Glyph.h 
https://bugs.webkit.org/show_bug.cgi?id=59087
Summary Centralize typedef unsigned short Glyph in Glyph.h
Nikolas Zimmermann
Reported Thursday, April 21, 2011 11:10:39 AM UTC
Centralize typedef unsigned short Glyph in Glyph.h
Attachments
Patch (9.46 KB, patch)
2011-04-21 03:29 PDT, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Patch v2 (9.69 KB, patch)
2011-04-21 03:49 PDT, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Patch v3 (9.73 KB, patch)
2011-04-21 04:37 PDT, Nikolas Zimmermann 		krit: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 Thursday, April 21, 2011 11:29:49 AM UTC
Created attachment 90507 [details] Patch
Nikolas Zimmermann
Comment 2 Thursday, April 21, 2011 11:49:03 AM UTC
Created attachment 90508 [details] Patch v2 Oops, the first patch got truncated.
WebKit Review Bot
Comment 3 Thursday, April 21, 2011 12:30:32 PM UTC
Attachment 90507 [details] did not build on mac: Build output: http://queues.webkit.org/results/8486418
Nikolas Zimmermann
Comment 4 Thursday, April 21, 2011 12:37:58 PM UTC
Created attachment 90510 [details] Patch v3 Set Glyph.h role to private -- accidently reverted this part of WebCore.xcodeproj, while splitting up my large master patch in smaller chunks.
WebKit Review Bot
Comment 5 Thursday, April 21, 2011 1:31:43 PM UTC
Attachment 90508 [details] did not build on mac: Build output: http://queues.webkit.org/results/8493125
Dirk Schulze
Comment 6 Thursday, April 21, 2011 2:06:50 PM UTC
Comment on attachment 90510 [details] Patch v3 A lot content for one patch ;-) r=me
Nikolas Zimmermann
Comment 7 Thursday, April 21, 2011 2:08:03 PM UTC
Landed in r84489.
Note You need to log in before you can comment on or make changes to this bug.