Bug 59087 - Centralize typedef unsigned short Glyph in Glyph.h
Summary: Centralize typedef unsigned short Glyph in Glyph.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks: 59085
  Show dependency treegraph
 
Reported: 2011-04-21 03:10 PDT by Nikolas Zimmermann
Modified: 2011-04-21 06:15 PDT (History)
1 user (show)

See Also:


Attachments
Patch (9.46 KB, patch)
2011-04-21 03:29 PDT, Nikolas Zimmermann
no flags Details | Formatted Diff | Diff
Patch v2 (9.69 KB, patch)
2011-04-21 03:49 PDT, Nikolas Zimmermann
no flags Details | Formatted Diff | Diff
Patch v3 (9.73 KB, patch)
2011-04-21 04:37 PDT, Nikolas Zimmermann
krit: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2011-04-21 03:10:39 PDT
Centralize typedef unsigned short Glyph in Glyph.h
Comment 1 Nikolas Zimmermann 2011-04-21 03:29:49 PDT
Created attachment 90507 [details]
Patch
Comment 2 Nikolas Zimmermann 2011-04-21 03:49:03 PDT
Created attachment 90508 [details]
Patch v2

Oops, the first patch got truncated.
Comment 3 WebKit Review Bot 2011-04-21 04:30:32 PDT
Attachment 90507 [details] did not build on mac:
Build output: http://queues.webkit.org/results/8486418
Comment 4 Nikolas Zimmermann 2011-04-21 04:37:58 PDT
Created attachment 90510 [details]
Patch v3

Set Glyph.h role to private -- accidently reverted this part of WebCore.xcodeproj, while splitting up my large master patch in smaller chunks.
Comment 5 WebKit Review Bot 2011-04-21 05:31:43 PDT
Attachment 90508 [details] did not build on mac:
Build output: http://queues.webkit.org/results/8493125
Comment 6 Dirk Schulze 2011-04-21 06:06:50 PDT
Comment on attachment 90510 [details]
Patch v3

A lot content for one patch ;-) r=me
Comment 7 Nikolas Zimmermann 2011-04-21 06:08:03 PDT
Landed in r84489.