Bug 59080 - Add FontItalics and FontSmallCaps enums to be used instead of boolean values.
Summary: Add FontItalics and FontSmallCaps enums to be used instead of boolean values.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-21 00:25 PDT by Luke Macpherson
Modified: 2011-04-22 01:45 PDT (History)
7 users (show)

See Also:

Attachments
Patch (8.63 KB, patch)
2011-04-21 00:28 PDT, Luke Macpherson 		no flags Details | Formatted Diff | Diff
Patch (8.74 KB, patch)
2011-04-21 17:39 PDT, Luke Macpherson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Macpherson 2011-04-21 00:25:31 PDT 
Add FontItalics and FontSmallCaps enums to be used instead of boolean values.
Comment 1 Luke Macpherson 2011-04-21 00:28:49 PDT 
Created attachment 90501 [details]
Patch
Comment 2 WebKit Review Bot 2011-04-21 00:53:42 PDT 
Attachment 90501 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8494028
Comment 3 Eric Seidel (no email) 2011-04-21 01:59:54 PDT 
Comment on attachment 90501 [details]
Patch

I'm surprised there are no callers of italic() or smallCaps()?
Comment 4 Luke Macpherson 2011-04-21 16:48:13 PDT 
(In reply to comment #3)
> (From update of attachment 90501 [details])
> I'm surprised there are no callers of italic() or smallCaps()?

There are two cases:
1) the form if(x->italic()), which has the same behavior since the *Off enum values are defined to be zero.
2) the form x->setItalic(y->italic), which is also covered by this CL.
Comment 5 Luke Macpherson 2011-04-21 17:39:47 PDT 
Created attachment 90642 [details]
Patch
Comment 6 WebKit Commit Bot 2011-04-22 00:40:48 PDT 
Comment on attachment 90642 [details]
Patch

Clearing flags on attachment: 90642

Committed r84609: <http://trac.webkit.org/changeset/84609>
Comment 7 WebKit Commit Bot 2011-04-22 00:40:53 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 WebKit Review Bot 2011-04-22 01:45:54 PDT 
http://trac.webkit.org/changeset/84609 might have broken WinCairo Debug (Build)