WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 59060
Remove redundant calls to RenderStyle::setDisplay()
https://bugs.webkit.org/show_bug.cgi?id=59060
Summary
Remove redundant calls to RenderStyle::setDisplay()
Luke Macpherson
Reported
2011-04-20 18:53:07 PDT
Remove redundant calls to RenderStyle::setDisplay()
Attachments
Patch
(2.45 KB, patch)
2011-04-20 20:25 PDT
,
Luke Macpherson
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Luke Macpherson
Comment 1
2011-04-20 20:25:19 PDT
Created
attachment 90482
[details]
Patch
Eric Seidel (no email)
Comment 2
2011-04-20 20:33:19 PDT
Comment on
attachment 90482
[details]
Patch Why is the other setDisplay call not neccessary?
Luke Macpherson
Comment 3
2011-04-20 20:41:25 PDT
(In reply to
comment #2
)
> (From update of
attachment 90482
[details]
) > Why is the other setDisplay call not neccessary?
The HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE(display, Display) macro results in setDisplay(*primitiveValue). This is what makes the other subsequent identical calls in else cases redundant.
WebKit Commit Bot
Comment 4
2011-04-21 23:14:04 PDT
Comment on
attachment 90482
[details]
Patch Clearing flags on attachment: 90482 Committed
r84603
: <
http://trac.webkit.org/changeset/84603
>
WebKit Commit Bot
Comment 5
2011-04-21 23:14:08 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug