Bug 59047 - [Qt] REGRESSION (r81479): build-webkit warning Inspector.idl is missing
Summary: [Qt] REGRESSION (r81479): build-webkit warning Inspector.idl is missing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P5 Minor
Assignee: Rafael Brandao
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-04-20 17:17 PDT by Rafael Brandao
Modified: 2011-05-01 07:12 PDT (History)
4 users (show)

See Also:


Attachments
Added variable_out to pipe output from one compiler to another and then forced the output to be added to the sources. (3.63 KB, patch)
2011-04-29 16:06 PDT, Rafael Brandao
no flags Details | Formatted Diff | Diff
Added variable_out to pipe output from one compiler to another and then forced the output to be added to the sources. (3.63 KB, patch)
2011-04-29 16:22 PDT, Rafael Brandao
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Brandao 2011-04-20 17:17:29 PDT
When you run "Tools/Scripts/build-webkit --qt --release" you get this warning:

Reading (...)/WebKit/Source/WebCore/DerivedSources.pro [(...)/WebKit/WebKitBuild/Release/WebCore]
WARNING: Failure to find: generated/Inspector.idl


I'm using WebKit (r84398) with Qt (v4.7.4).
Comment 1 Rafael Brandao 2011-04-20 17:31:54 PDT
The patch that caused this regression adds a generator and it should generate Inspector.idl before anything needs it.

If you change the line that contains "inspectorIDL.input = INSPECTOR_IDL" to "inspectorIDL.input = $${WC_GENERATED_SOURCES_DIR}/Inspector.idl" on Source/WebCore/CodeGenerators.pri, the warning disappear. The problem is the build will not succeed in this case. For some yet unknown reason, the file "InspectorFrontend.h" is not generated, but necessary to "InspectorDebuggerAgent.h".
Comment 2 Rafael Brandao 2011-04-27 07:39:53 PDT
Nevermind, I've figured out that when you create a qmake target, the input value expects a variable that contains the files that should be processed, so changing it to the files itself makes it stop working, that's why the warning was not showing up, and that also explains why the files did not generate after all.
Comment 3 Rafael Brandao 2011-04-29 16:06:07 PDT
Created attachment 91759 [details]
Added variable_out to pipe output from one compiler to another and then forced the output to be added to the sources.

It was necessary to use variable_out to disable the annoying warning (http://bugreports.qt.nokia.com/browse/QTBUG-18938). As that variable should be added as input of the other generator, and this generator was used first in WebCore/DerivedSources.pro and then later at WebKit/qt/QtWebKit.pro, there was an issue with the input value, as it wasn't set at the later moment, and that would make the output to not be added to the sources. So I've made use of this already existing attribute called "wkExtraSources" to make sure that, in this special case, the output would be added anyway.
Comment 4 Rafael Brandao 2011-04-29 16:22:25 PDT
Created attachment 91763 [details]
Added variable_out to pipe output from one compiler to another and then forced the output to be added to the sources.

It was necessary to use variable_out to disable the annoying warning (http://bugreports.qt.nokia.com/browse/QTBUG-18938). As that variable should be added as input of the other generator, and this generator was used first in WebCore/DerivedSources.pro and then later at WebKit/qt/QtWebKit.pro, there was an issue with the input value, as it wasn't set at the later moment, and that would make the output to not be added to the sources. So I've made use of this already existing attribute called "wkExtraSources" to make sure that, in this special case, the output would be added anyway.
Comment 5 Andras Becsi 2011-05-01 01:59:26 PDT
Comment on attachment 91763 [details]
Added variable_out to pipe output from one compiler to another and then forced the output to be added to the sources.

LGTM, though I'm not a reviewer.

Thanks for fixing this.
Comment 6 Csaba Osztrogonác 2011-05-01 05:01:53 PDT
Comment on attachment 91763 [details]
Added variable_out to pipe output from one compiler to another and then forced the output to be added to the sources.

Great fix, r=me.
Comment 7 WebKit Commit Bot 2011-05-01 07:12:18 PDT
Comment on attachment 91763 [details]
Added variable_out to pipe output from one compiler to another and then forced the output to be added to the sources.

Clearing flags on attachment: 91763

Committed r85412: <http://trac.webkit.org/changeset/85412>
Comment 8 WebKit Commit Bot 2011-05-01 07:12:23 PDT
All reviewed patches have been landed.  Closing bug.