Bug 59045 - Check for null m_context in WebGLLayerChromium and add resetting platform layer's context in the destructor of GraphicsContext3D.
Summary: Check for null m_context in WebGLLayerChromium and add resetting platform lay...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Alexey Marinichev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-20 17:17 PDT by Alexey Marinichev
Modified: 2011-04-20 18:38 PDT (History)
2 users (show)

See Also:


Attachments
Patch (4.37 KB, patch)
2011-04-20 17:20 PDT, Alexey Marinichev
no flags Details | Formatted Diff | Diff
Patch (4.37 KB, patch)
2011-04-20 17:53 PDT, Alexey Marinichev
no flags Details | Formatted Diff | Diff
Patch (4.52 KB, patch)
2011-04-20 18:00 PDT, Alexey Marinichev
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Marinichev 2011-04-20 17:17:18 PDT
Check for null m_context in WebGLLayerChromium and add resetting platform layer's context in the destructor of GraphicsContext3D.
Comment 1 Alexey Marinichev 2011-04-20 17:20:33 PDT
Created attachment 90454 [details]
Patch
Comment 2 Alexey Marinichev 2011-04-20 17:23:13 PDT
This is to avoid dereferencing stale pointer when recovering from lost context.
Comment 3 Kenneth Russell 2011-04-20 17:37:31 PDT
Comment on attachment 90454 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90454&action=review

The code change looks good. We've talked offline about the fact that it's only feasible to test this in an automated fashion with a Chromium browser test, which is being worked on. Unfortunately there's a problem with the ChangeLog that needs to be fixed.

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

The commit queue will reject this patch because of the presence of this line. You'll need to update it with information about the testing status.
Comment 4 Alexey Marinichev 2011-04-20 17:53:19 PDT
Created attachment 90460 [details]
Patch
Comment 5 Alexey Marinichev 2011-04-20 18:00:05 PDT
Created attachment 90462 [details]
Patch
Comment 6 Kenneth Russell 2011-04-20 18:09:48 PDT
Comment on attachment 90462 [details]
Patch

Looks good. r=me
Comment 7 WebKit Commit Bot 2011-04-20 18:38:27 PDT
Comment on attachment 90462 [details]
Patch

Clearing flags on attachment: 90462

Committed r84449: <http://trac.webkit.org/changeset/84449>
Comment 8 WebKit Commit Bot 2011-04-20 18:38:32 PDT
All reviewed patches have been landed.  Closing bug.