Bug 59032 - [Mac]Regression: extending word that is already marked misspelled doesn't remove misspelling underline.
Summary: [Mac]Regression: extending word that is already marked misspelled doesn't rem...
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.6
: P2 Normal
Assignee: Jia Pu
Keywords: InRadar
Depends on:
Reported: 2011-04-20 16:18 PDT by Jia Pu
Modified: 2011-04-20 18:28 PDT (History)
2 users (show)

See Also:

Patch (v1) (3.47 KB, patch)
2011-04-20 17:16 PDT, Jia Pu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jia Pu 2011-04-20 16:18:15 PDT
If the word "brough" is already marked as misspelled, appending "t" at the end doesn't remove the misspelling marker. 

This is a regression introduced in changeset 83344. In Editor.cpp, "removeSpellAndCorrectionMarkersFromWordsToBeEdited(isSpaceOrNewline(text[0])); " is replaced "updateMarkersForWordsAffectedByEditing(text[0]);", and the the call to isSpaceOrNewline() is missing.
Comment 1 Jia Pu 2011-04-20 17:03:16 PDT
Comment 2 Jia Pu 2011-04-20 17:16:48 PDT
Created attachment 90452 [details]
Patch (v1)
Comment 3 Maciej Stachowiak 2011-04-20 17:32:59 PDT
Comment on attachment 90452 [details]
Patch (v1)

Comment 4 WebKit Commit Bot 2011-04-20 18:26:29 PDT
The commit-queue encountered the following flaky tests while processing attachment 90452 [details]:

animations/suspend-resume-animation.html bug 48161 (author: cmarrin@apple.com)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2011-04-20 18:28:46 PDT
Comment on attachment 90452 [details]
Patch (v1)

Clearing flags on attachment: 90452

Committed r84448: <http://trac.webkit.org/changeset/84448>
Comment 6 WebKit Commit Bot 2011-04-20 18:28:51 PDT
All reviewed patches have been landed.  Closing bug.