Bug 59031 - initial set of tests for new results.html file
Summary: initial set of tests for new results.html file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-20 16:10 PDT by Ojan Vafai
Modified: 2011-04-21 10:16 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.57 KB, patch)
2011-04-20 16:11 PDT, Ojan Vafai 		no flags Details | Formatted Diff | Diff
Patch (5.71 KB, patch)
2011-04-20 16:29 PDT, Ojan Vafai 		tony: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2011-04-20 16:10:16 PDT 
initial set of tests for new results.html file
Comment 1 Ojan Vafai 2011-04-20 16:11:24 PDT 
Created attachment 90433 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-04-20 16:18:07 PDT 
Comment on attachment 90433 [details]
Patch

How does one run the tests?
Comment 3 Ojan Vafai 2011-04-20 16:29:03 PDT 
Created attachment 90439 [details]
Patch
Comment 4 Ojan Vafai 2011-04-20 16:29:32 PDT 
You load json_results.html in a browser. Added comments to the top of json_results_test.js explaining this.
Comment 5 Eric Seidel (no email) 2011-04-20 16:34:14 PDT 
Comment on attachment 90439 [details]
Patch

I see, so json_results.html is the template off of which results.html is based?  I'm confused.
Comment 6 Ojan Vafai 2011-04-20 16:36:02 PDT 
(In reply to comment #5)
> (From update of attachment 90439 [details])
> I see, so json_results.html is the template off of which results.html is based?  I'm confused.

It just gets renamed in the copy. Eventually, I'll rename it to results.html and rename this js file to results_test.html.
Comment 7 Tony Chang 2011-04-21 09:57:48 PDT 
Comment on attachment 90439 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90439&action=review

Ojan and I discussed moving this into LayoutTests/fast/harness so it'll be run automatically (in a follow up patch).

> Tools/Scripts/webkitpy/layout_tests/layout_package/json_results.html:589
> +<script src="json_results_test.js"></script>

Nit: Please add a comment explaining why this doesn't run when the user is viewing results.html.
Comment 8 Ojan Vafai 2011-04-21 10:16:42 PDT 
Committed r84514: <http://trac.webkit.org/changeset/84514>