Bug 59018 – [chromium] Move Chromium media controls into own root element

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Steve Lacey]

Create MediaControlRootElementChromium and strip unused stuff.

This should be basically a noop.

[Steve Lacey]

Created attachment 90403 [details]
Patch

[Eric Carlson]

Comment on attachment 90403 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90403&action=review

> Source/WebCore/ChangeLog:10
> +        No new tests. (OOPS!)

THe "OOPS" will prevent your patch from being committed. If no new tests are necessary, please explain why.

> Source/WebCore/ChangeLog:40
> +        * css/mediaControlsChromium.css:
> +        (audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
> +        * html/shadow/MediaControlRootElementChromium.cpp: Added.
> +        (WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
> +        (WebCore::MediaControls::create):
> +        (WebCore::MediaControlRootElementChromium::create):
> +        (WebCore::MediaControlRootElementChromium::show):
> +        (WebCore::MediaControlRootElementChromium::hide):
> +        (WebCore::webkitTransitionString):
> +        (WebCore::opacityString):
> +        (WebCore::MediaControlRootElementChromium::makeOpaque):
> +        (WebCore::MediaControlRootElementChromium::makeTransparent):
> +        (WebCore::MediaControlRootElementChromium::reset):
> +        (WebCore::MediaControlRootElementChromium::playbackStarted):
> +        (WebCore::MediaControlRootElementChromium::playbackProgressed):
> +        (WebCore::MediaControlRootElementChromium::playbackStopped):
> +        (WebCore::MediaControlRootElementChromium::updateTimeDisplay):
> +        (WebCore::MediaControlRootElementChromium::reportedError):
> +        (WebCore::MediaControlRootElementChromium::changedNetworkState):
> +        (WebCore::MediaControlRootElementChromium::loadedMetadata):
> +        (WebCore::MediaControlRootElementChromium::changedClosedCaptionsVisibility):
> +        (WebCore::MediaControlRootElementChromium::changedMute):
> +        (WebCore::MediaControlRootElementChromium::changedVolume):
> +        (WebCore::MediaControlRootElementChromium::enteredFullscreen):
> +        (WebCore::MediaControlRootElementChromium::exitedFullscreen):
> +        (WebCore::MediaControlRootElementChromium::showVolumeSlider):
> +        (WebCore::MediaControlRootElementChromium::shadowPseudoId):
> +        * html/shadow/MediaControlRootElementChromium.h: Added.

If these files were just cloned from existing files you should say so, and there is no need to list all of the "changed" functions here. If they aren't exact clones, please say what changed in each function.

[Steve Lacey]

Sorry - still fairly to this. I just went with what prepare-ChangeLog did.

So yes, MediaControlRootElementChromium is a clone of MediaControlRootElement, with all unused code removed.

Will fix.

[Steve Lacey]

Created attachment 90408 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 90408 [details]
Patch

Clearing flags on attachment: 90408

Committed r84429: <http://trac.webkit.org/changeset/84429>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.