Bug 59018 - [chromium] Move Chromium media controls into own root element
Summary: [chromium] Move Chromium media controls into own root element
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-20 12:45 PDT by Steve Lacey
Modified: 2011-04-20 15:58 PDT (History)
3 users (show)

See Also:


Attachments
Patch (18.84 KB, patch)
2011-04-20 13:42 PDT, Steve Lacey
no flags Details | Formatted Diff | Diff
Patch (17.33 KB, patch)
2011-04-20 14:08 PDT, Steve Lacey
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Lacey 2011-04-20 12:45:09 PDT
Create MediaControlRootElementChromium and strip unused stuff.

This should be basically a noop.
Comment 1 Steve Lacey 2011-04-20 13:42:49 PDT
Created attachment 90403 [details]
Patch
Comment 2 Eric Carlson 2011-04-20 13:52:59 PDT
Comment on attachment 90403 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90403&action=review

> Source/WebCore/ChangeLog:10
> +        No new tests. (OOPS!)

THe "OOPS" will prevent your patch from being committed. If no new tests are necessary, please explain why.

> Source/WebCore/ChangeLog:40
> +        * css/mediaControlsChromium.css:
> +        (audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
> +        * html/shadow/MediaControlRootElementChromium.cpp: Added.
> +        (WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
> +        (WebCore::MediaControls::create):
> +        (WebCore::MediaControlRootElementChromium::create):
> +        (WebCore::MediaControlRootElementChromium::show):
> +        (WebCore::MediaControlRootElementChromium::hide):
> +        (WebCore::webkitTransitionString):
> +        (WebCore::opacityString):
> +        (WebCore::MediaControlRootElementChromium::makeOpaque):
> +        (WebCore::MediaControlRootElementChromium::makeTransparent):
> +        (WebCore::MediaControlRootElementChromium::reset):
> +        (WebCore::MediaControlRootElementChromium::playbackStarted):
> +        (WebCore::MediaControlRootElementChromium::playbackProgressed):
> +        (WebCore::MediaControlRootElementChromium::playbackStopped):
> +        (WebCore::MediaControlRootElementChromium::updateTimeDisplay):
> +        (WebCore::MediaControlRootElementChromium::reportedError):
> +        (WebCore::MediaControlRootElementChromium::changedNetworkState):
> +        (WebCore::MediaControlRootElementChromium::loadedMetadata):
> +        (WebCore::MediaControlRootElementChromium::changedClosedCaptionsVisibility):
> +        (WebCore::MediaControlRootElementChromium::changedMute):
> +        (WebCore::MediaControlRootElementChromium::changedVolume):
> +        (WebCore::MediaControlRootElementChromium::enteredFullscreen):
> +        (WebCore::MediaControlRootElementChromium::exitedFullscreen):
> +        (WebCore::MediaControlRootElementChromium::showVolumeSlider):
> +        (WebCore::MediaControlRootElementChromium::shadowPseudoId):
> +        * html/shadow/MediaControlRootElementChromium.h: Added.

If these files were just cloned from existing files you should say so, and there is no need to list all of the "changed" functions here. If they aren't exact clones, please say what changed in each function.
Comment 3 Steve Lacey 2011-04-20 14:01:29 PDT
Sorry - still fairly to this. I just went with what prepare-ChangeLog did.

So yes, MediaControlRootElementChromium is a clone of MediaControlRootElement, with all unused code removed.

Will fix.
Comment 4 Steve Lacey 2011-04-20 14:08:23 PDT
Created attachment 90408 [details]
Patch
Comment 5 WebKit Commit Bot 2011-04-20 15:58:02 PDT
Comment on attachment 90408 [details]
Patch

Clearing flags on attachment: 90408

Committed r84429: <http://trac.webkit.org/changeset/84429>
Comment 6 WebKit Commit Bot 2011-04-20 15:58:07 PDT
All reviewed patches have been landed.  Closing bug.