Bug 59014 - Support DataView in workers
Summary: Support DataView in workers
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Jian Li
Depends on:
Reported: 2011-04-20 11:56 PDT by Jian Li
Modified: 2011-04-20 14:38 PDT (History)
1 user (show)

See Also:

Proposed Patch (3.49 KB, patch)
2011-04-20 11:58 PDT, Jian Li
kbr: review+
jianli: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jian Li 2011-04-20 11:56:40 PDT
We need to add support for DataView in workers.
Comment 1 Jian Li 2011-04-20 11:58:24 PDT
Created attachment 90376 [details]
Proposed Patch
Comment 2 Kenneth Russell 2011-04-20 13:37:00 PDT
Comment on attachment 90376 [details]
Proposed Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90376&action=review

Looks good. One minor comment about the test.

> LayoutTests/fast/canvas/webgl/resources/worker-data-view-test.js:2
> +    var array = new Uint8Array(4);

It would be safer to write this as "new Uint32Array(1)".
Comment 3 Jian Li 2011-04-20 14:38:50 PDT
Committed as https://trac.webkit.org/changeset/84418.