Bug 59010 - [chromium] expose title text direction on WebDataSource
Summary: [chromium] expose title text direction on WebDataSource
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Evan Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-20 11:14 PDT by Evan Martin
Modified: 2011-04-20 14:05 PDT (History)
1 user (show)

See Also:


Attachments
Patch (3.03 KB, patch)
2011-04-20 11:14 PDT, Evan Martin
no flags Details | Formatted Diff | Diff
Patch (3.10 KB, patch)
2011-04-20 11:17 PDT, Evan Martin
tony: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Evan Martin 2011-04-20 11:14:06 PDT
[chromium] expose text direction WebDataSource
Comment 1 Evan Martin 2011-04-20 11:14:51 PDT
Created attachment 90368 [details]
Patch
Comment 2 Evan Martin 2011-04-20 11:17:42 PDT
Created attachment 90369 [details]
Patch
Comment 3 Evan Martin 2011-04-20 11:54:23 PDT
Committed r84400: <http://trac.webkit.org/changeset/84400>
Comment 4 Darin Fisher (:fishd, Google) 2011-04-20 12:45:01 PDT
Comment on attachment 90369 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90369&action=review

> Source/WebKit/chromium/src/WebDataSourceImpl.cpp:90
> +    return title().direction() == LTR ? WebTextDirectionLeftToRight : WebTextDirectionRightToLeft;

would it make sense for the WebKit API to have a WebStringWithDirection?  maybe we will want to shuttle this information across the webkit API in other places in the future too?
Comment 5 Evan Martin 2011-04-20 13:30:14 PDT
Comment on attachment 90369 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90369&action=review

>> Source/WebKit/chromium/src/WebDataSourceImpl.cpp:90
>> +    return title().direction() == LTR ? WebTextDirectionLeftToRight : WebTextDirectionRightToLeft;
> 
> would it make sense for the WebKit API to have a WebStringWithDirection?  maybe we will want to shuttle this information across the webkit API in other places in the future too?

I *believe* this and the didReceiveTitle are the only two, so I was hoping to keep it simple for now.  Is it ok if I just keep this idea in mind for the future?
Comment 6 Darin Fisher (:fishd, Google) 2011-04-20 14:05:08 PDT
(In reply to comment #5)
> I *believe* this and the didReceiveTitle are the only two, so I was hoping to keep it simple for now.  Is it ok if I just keep this idea in mind for the future?

Yes, that's probably OK.  A quick grep of chromium/public/ suggests a couple other places where WebStringWithDirection might be useful:

  WebViewClient::setTooltipText
  WebNotification::{title,body,direction}