Bug 59010 – [chromium] expose title text direction on WebDataSource

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Evan Martin]

[chromium] expose text direction WebDataSource

[Evan Martin]

Created attachment 90368 [details]
Patch

[Evan Martin]

Created attachment 90369 [details]
Patch

[Evan Martin]

Committed r84400: <http://trac.webkit.org/changeset/84400>

[Darin Fisher (:fishd, Google)]

Comment on attachment 90369 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90369&action=review

> Source/WebKit/chromium/src/WebDataSourceImpl.cpp:90
> +    return title().direction() == LTR ? WebTextDirectionLeftToRight : WebTextDirectionRightToLeft;

would it make sense for the WebKit API to have a WebStringWithDirection?  maybe we will want to shuttle this information across the webkit API in other places in the future too?

[Evan Martin]

Comment on attachment 90369 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90369&action=review

>> Source/WebKit/chromium/src/WebDataSourceImpl.cpp:90
>> +    return title().direction() == LTR ? WebTextDirectionLeftToRight : WebTextDirectionRightToLeft;
> 
> would it make sense for the WebKit API to have a WebStringWithDirection?  maybe we will want to shuttle this information across the webkit API in other places in the future too?

I *believe* this and the didReceiveTitle are the only two, so I was hoping to keep it simple for now.  Is it ok if I just keep this idea in mind for the future?

[Darin Fisher (:fishd, Google)]

(In reply to comment #5)
> I *believe* this and the didReceiveTitle are the only two, so I was hoping to keep it simple for now.  Is it ok if I just keep this idea in mind for the future?

Yes, that's probably OK.  A quick grep of chromium/public/ suggests a couple other places where WebStringWithDirection might be useful:

  WebViewClient::setTooltipText
  WebNotification::{title,body,direction}