Bug 59009 - [Mac] Like autocorrection, other types of substitution need to respect undo.
Summary: [Mac] Like autocorrection, other types of substitution need to respect undo.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh Intel OS X 10.6
: P2 Normal
Assignee: Jia Pu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-04-20 10:50 PDT by Jia Pu
Modified: 2011-04-20 16:35 PDT (History)
3 users (show)

See Also:

Attachments
Patch (8.78 KB, patch)
2011-04-20 11:00 PDT, Jia Pu 		no flags Details | Formatted Diff | Diff
Patch (v2) (8.78 KB, patch)
2011-04-20 14:46 PDT, Jia Pu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jia Pu 2011-04-20 10:50:17 PDT 
On Mac, when text substitution is turned on, (c) will get converted to © automatically. However, if user undid such substitution, then we shouldn't convert it again. This should also apply to automatically adding link to url string. 

<rdar://problem/8601537>
Comment 1 Jia Pu 2011-04-20 11:00:19 PDT 
Created attachment 90361 [details]
Patch
Comment 2 Adele Peterson 2011-04-20 14:30:24 PDT 
Comment on attachment 90361 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90361&action=review

> Source/WebCore/ChangeLog:9
> +        Similar to autocorreciton, we use SpellingCorrectionCommand to carry out other types of text substitution, so that

Typo - "autocorrection"
Comment 3 Jia Pu 2011-04-20 14:46:44 PDT 
Created attachment 90419 [details]
Patch (v2)
Comment 4 WebKit Commit Bot 2011-04-20 16:35:30 PDT 
Comment on attachment 90419 [details]
Patch (v2)

Clearing flags on attachment: 90419

Committed r84433: <http://trac.webkit.org/changeset/84433>
Comment 5 WebKit Commit Bot 2011-04-20 16:35:36 PDT 
All reviewed patches have been landed.  Closing bug.