WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
59008
[buildbot]Show more recent builds on builder page
https://bugs.webkit.org/show_bug.cgi?id=59008
Summary
[buildbot]Show more recent builds on builder page
Csaba Osztrogonác
Reported
2011-04-20 10:44:24 PDT
If I click on a builder on waterfall page, I can see only 5 builds under the recent builds. It would be great if we can see more than 5 to make gardening more effective. I know that I can add "?numbuilds=100" to the URL, but it isn't so user friendly. Can't we add this option to master.cfg somehow?
Attachments
template patch
(3.59 KB, patch)
2011-04-20 11:01 PDT
,
Peter Gal
ossy
: review-
ossy
: commit-queue-
Details
Formatted Diff
Diff
base template
(3.38 KB, patch)
2011-04-20 11:57 PDT
,
Peter Gal
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Peter Gal
Comment 1
2011-04-20 10:57:31 PDT
(In reply to
comment #0
)
> If I click on a builder on waterfall page, > I can see only 5 builds under the recent builds. > > It would be great if we can see more than 5 to make gardening more effective. > I know that I can add "?numbuilds=100" to the URL, but it isn't so user friendly. > Can't we add this option to master.cfg somehow?
It is possible to pass 'numbuilds' argument to the WebStatus in the master.cfg, but that does not affects the builder's page. But we can override the build in template which will contain the required extra links.
Peter Gal
Comment 2
2011-04-20 11:01:03 PDT
Created
attachment 90362
[details]
template patch Simply added these lines to the built-in template: ( Show: <a href="{{ builder_url }}">default</a> {% for count in [25, 50, 100, 200] %} <a href="{{ builder_url }}?numbuilds={{ count }}">{{ count }}</a> {% endfor %}) This will show five links with different 'numbuilds' parameters.
Csaba Osztrogonác
Comment 3
2011-04-20 11:03:43 PDT
Comment on
attachment 90362
[details]
template patch yay, shibbbyyyy! r=me
Csaba Osztrogonác
Comment 4
2011-04-20 11:05:08 PDT
Adam, could you run a reconfigure on the buildmaster after it is landed?
Peter Gal
Comment 5
2011-04-20 11:05:53 PDT
BTW, this template is from Buildbot v0.8.3, so it should apply cleanly to the apple's buildmaster.
Adam Roben (:aroben)
Comment 6
2011-04-20 11:28:44 PDT
It would be slightly clearer to check in the unmodified template first, and then customize it after that in a separate change. I can take care of updating the master after this lands.
Csaba Osztrogonác
Comment 7
2011-04-20 11:32:19 PDT
Comment on
attachment 90362
[details]
template patch OK, let's check in the unmodified template first, and then patch it.
Peter Gal
Comment 8
2011-04-20 11:57:22 PDT
Created
attachment 90375
[details]
base template This is the built-in template from buildbot v0.8.3.
WebKit Commit Bot
Comment 9
2011-04-20 13:17:52 PDT
The commit-queue encountered the following flaky tests while processing
attachment 90362
[details]
: http/tests/xmlhttprequest/logout.html
bug 52047
(author:
ap@webkit.org
) The commit-queue is continuing to process your patch.
Csaba Osztrogonác
Comment 10
2011-04-20 14:50:16 PDT
Comment on
attachment 90375
[details]
base template Landed in
http://trac.webkit.org/changeset/84421
Csaba Osztrogonác
Comment 11
2011-04-20 14:58:47 PDT
Modifying the default template landed in
http://trac.webkit.org/changeset/84423
WebKit Review Bot
Comment 12
2011-04-20 15:05:20 PDT
http://trac.webkit.org/changeset/84423
might have broken Chromium Win Release
Peter Gal
Comment 13
2011-04-21 02:20:21 PDT
(In reply to
comment #11
)
> Modifying the default template landed in
http://trac.webkit.org/changeset/84423
Cool, Thanks!
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug