Bug 59003 - Update fast/canvas/font-update.html to use dumpAsText
Summary: Update fast/canvas/font-update.html to use dumpAsText
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Matthew Delaney
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-20 09:39 PDT by Matthew Delaney
Modified: 2011-04-20 10:07 PDT (History)
0 users

See Also:

Attachments
Patch (1.75 KB, patch)
2011-04-20 09:40 PDT, Matthew Delaney 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Delaney 2011-04-20 09:39:14 PDT 
Update fast/canvas/font-update.html to use dumpAsText
Comment 1 Matthew Delaney 2011-04-20 09:40:09 PDT 
Created attachment 90350 [details]
Patch
Comment 2 Adam Roben (:aroben) 2011-04-20 09:42:48 PDT 
Comment on attachment 90350 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90350&action=review

> LayoutTests/ChangeLog:9
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Update fast/canvas/font-update.html to use dumpAsText
> +        https://bugs.webkit.org/show_bug.cgi?id=59003
> +
> +        * fast/canvas/font-update-expected.txt:
> +        * fast/canvas/font-update.html:

Your ChangeLog should explain why this is an OK thing to do. Explaining the purpose of the test will probably be part of that. (E.g., if the test is just detecting a crash, then dumpAsText is probably fine.)
Comment 3 Matthew Delaney 2011-04-20 10:07:02 PDT 
Committed r84390: <http://trac.webkit.org/changeset/84390>