Bug 58996 – Web Inspector: [protocol] Paused event should expose exception value that caused it

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Peter Rybin]

The protocol allows "pause on exception" mode. When this is enabled, JavaScript VM pauses on exception being thrown and WebKit sends "Paused" event.

However there is no information about exception being thrown.

The protocol should give full access to the exception value (with its properties, type etc).

[Yury Semikhatsky]

Created attachment 91102 [details]
Patch

[Build Bot]

Attachment 91102 [details] did not build on win:
Build output: http://queues.webkit.org/results/8510611

[Yury Semikhatsky]

Created attachment 91112 [details]
Patch

[Yury Semikhatsky]

Created attachment 91113 [details]
Patch

[Build Bot]

Attachment 91113 [details] did not build on win:
Build output: http://queues.webkit.org/results/8509671

[Yury Semikhatsky]

Created attachment 91246 [details]
Patch

[Pavel Feldman]

Comment on attachment 91246 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91246&action=review

> Source/WebCore/bindings/v8/ScriptDebugServer.cpp:221
> +        contextScope.set(new v8::Context::Scope(v8::Debug::GetDebugContext()));

Poor merge?

> Source/WebCore/bindings/v8/ScriptDebugServer.cpp:341
> +                if (!exceptionGetterValue.IsEmpty() && exceptionGetterValue->IsFunction()) {

Could you put ASSERT here?

[Yury Semikhatsky]

Created attachment 91255 [details]
Patch for landing

All comments have been addressed.

[Yury Semikhatsky]

Committed r85035: <http://trac.webkit.org/changeset/85035>

[WebKit Review Bot]

http://trac.webkit.org/changeset/85035 might have broken Chromium Linux Release