Bug 58993 - Web Inspector: persist local resource history between inspector / browser launches.
Summary: Web Inspector: persist local resource history between inspector / browser lau...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-20 08:21 PDT by Pavel Feldman
Modified: 2011-04-21 07:07 PDT (History)
13 users (show)

See Also:


Attachments
Patch (5.44 KB, patch)
2011-04-20 08:28 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
[PATCH] With the loaderId check. (7.10 KB, patch)
2011-04-20 11:06 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-04-20 08:21:22 PDT
Patch to follow.
Comment 1 Pavel Feldman 2011-04-20 08:28:04 PDT
Created attachment 90341 [details]
Patch
Comment 2 Yury Semikhatsky 2011-04-20 09:32:29 PDT
Comment on attachment 90341 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90341&action=review

> Source/WebCore/inspector/front-end/Resource.js:742
>          this._content = newContent;

This way the content displayed in the inspector will differ from the actual one after the restore.
Comment 3 Pavel Feldman 2011-04-20 11:06:10 PDT
Created attachment 90365 [details]
[PATCH] With the loaderId check.
Comment 4 Yury Semikhatsky 2011-04-21 04:25:02 PDT
Comment on attachment 90365 [details]
[PATCH] With the loaderId check.

View in context: https://bugs.webkit.org/attachment.cgi?id=90365&action=review

> Source/WebCore/inspector/front-end/ResourceTreeModel.js:306
>          resource.frameId = frame.id;

Consider passing all of these values as parameter to the constructor.
Comment 5 Pavel Feldman 2011-04-21 04:43:59 PDT
Comment on attachment 90365 [details]
[PATCH] With the loaderId check.

Clearing flags on attachment: 90365

Committed r84483: <http://trac.webkit.org/changeset/84483>
Comment 6 Pavel Feldman 2011-04-21 04:44:08 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Review Bot 2011-04-21 07:07:09 PDT
http://trac.webkit.org/changeset/84483 might have broken GTK Linux 32-bit Debug
The following tests are not passing:
media/controls-strict.html