Bug 58987 - [Qt] Clean the style of our cookie methods
Summary: [Qt] Clean the style of our cookie methods
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P5 Enhancement
Assignee: Benjamin Poulain
URL:
Keywords: EasyFix, Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-04-20 07:03 PDT by Benjamin Poulain
Modified: 2011-04-20 07:47 PDT (History)
0 users

See Also:


Attachments
Patch (3.20 KB, patch)
2011-04-20 07:08 PDT, Benjamin Poulain
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2011-04-20 07:03:24 PDT
There are unused variables, invalid char* conversion and useless url conversions.
Comment 1 Benjamin Poulain 2011-04-20 07:08:42 PDT
Created attachment 90338 [details]
Patch
Comment 2 Andreas Kling 2011-04-20 07:32:14 PDT
Comment on attachment 90338 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90338&action=review

Please provide SunSpider numbers.

> Source/WebCore/ChangeLog:13
> +        (WebCore::cookies): foreach() should use ref to const as for Qt.

s/ref to const as/const references/
Comment 3 Benjamin Poulain 2011-04-20 07:47:45 PDT
Committed r84373: <http://trac.webkit.org/changeset/84373>