WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
58987
[Qt] Clean the style of our cookie methods
https://bugs.webkit.org/show_bug.cgi?id=58987
Summary
[Qt] Clean the style of our cookie methods
Benjamin Poulain
Reported
2011-04-20 07:03:24 PDT
There are unused variables, invalid char* conversion and useless url conversions.
Attachments
Patch
(3.20 KB, patch)
2011-04-20 07:08 PDT
,
Benjamin Poulain
kling
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Benjamin Poulain
Comment 1
2011-04-20 07:08:42 PDT
Created
attachment 90338
[details]
Patch
Andreas Kling
Comment 2
2011-04-20 07:32:14 PDT
Comment on
attachment 90338
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=90338&action=review
Please provide SunSpider numbers.
> Source/WebCore/ChangeLog:13 > + (WebCore::cookies): foreach() should use ref to const as for Qt.
s/ref to const as/const references/
Benjamin Poulain
Comment 3
2011-04-20 07:47:45 PDT
Committed
r84373
: <
http://trac.webkit.org/changeset/84373
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug