Bug 58968 - [GTK] Build libWebCore with the gtk sources too
Summary: [GTK] Build libWebCore with the gtk sources too
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-20 00:06 PDT by Carlos Garcia Campos
Modified: 2011-04-20 15:43 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.05 KB, patch)
2011-04-20 00:10 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2011-04-20 00:06:53 PDT 
Currently webcore gtk sources are compiled as part of the libwebkitgtk sources, I think they should be moved to libWebCore, since libwebkitgtk already uses libWebCore.la.
Comment 1 Carlos Garcia Campos 2011-04-20 00:10:37 PDT 
Created attachment 90319 [details]
Patch

This change also improves the build time.
Comment 2 Martin Robinson 2011-04-20 08:41:39 PDT 
Comment on attachment 90319 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90319&action=review

> Source/WebCore/ChangeLog:8
> +        [GTK] Build libWebCore with the gtk sources too
> +        https://bugs.webkit.org/show_bug.cgi?id=58968
> +
> +        * GNUmakefile.am: Add webcore gtk sources to libWebCore sources.

Please include in your ChangeLog the motivations for this change, so that people browsing the repository know what's up.
Comment 3 Carlos Garcia Campos 2011-04-20 09:21:48 PDT 
Committed r84381: <http://trac.webkit.org/changeset/84381>
Comment 4 WebKit Review Bot 2011-04-20 15:43:50 PDT 
http://trac.webkit.org/changeset/84381 might have broken WinCairo Debug (Build)