Bug 58964 – Allow casting between CSSPrimitiveValue and EBorderCollapse to remove special-case logic from CSSStyleSelector.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Luke Macpherson]

Allow casting between CSSPrimitiveValue and EBorderCollapse to remove special-case logic from CSSStyleSelector.

[Luke Macpherson]

Created attachment 90308 [details]
Patch

[WebKit Review Bot]

Attachment 90308 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/rendering/style/RenderStyle.h:196:  _border_collapse is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Luke Macpherson]

Style fail is due to legacy code.
Let me know what you think. Seems that there are a lot of these cases that when fixed will greatly simplify CSSStyleSelector/CSSStyleApplyProperty.

[Eric Seidel (no email)]

Comment on attachment 90308 [details]
Patch

Sounds good to me.  style->borderColapse() isn't called anywhere?

[Simon Fraser (smfr)]

Comment on attachment 90308 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90308&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests as no new functinoality added.

Typo

[Luke Macpherson]

Created attachment 90309 [details]
Patch

[WebKit Review Bot]

Attachment 90309 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/rendering/style/RenderStyle.h:196:  _border_collapse is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Luke Macpherson]

(In reply to comment #4)
> (From update of attachment 90308 [details])
> Sounds good to me.  style->borderColapse() isn't called anywhere?

The enum maps to 0,1 in the same way as the boolean.
Also the place it gets called in CSSStyleSelector (in the macro) is of the form set(get()).

[Luke Macpherson]

(In reply to comment #5)
> (From update of attachment 90308 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=90308&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        No new tests as no new functinoality added.
> 
> Typo

Fixed.

[WebKit Commit Bot]

Comment on attachment 90309 [details]
Patch

Clearing flags on attachment: 90309

Committed r84380: <http://trac.webkit.org/changeset/84380>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/84380 might have broken Qt Linux Release minimal

[Dimitri Glazkov (Google)]

(In reply to comment #12)
> http://trac.webkit.org/changeset/84380 might have broken Qt Linux Release minimal

Fix landed as http://trac.webkit.org/changeset/84385.