The MacroAssembler currently exposes x86's weird behaviour that the setcc instruction only sets the low 8 bits of a register. Stop that. Having done so, to clarify remove the 'set32' prefix from test & compare instructions - these methods all now set a full 32/64 bit register (Ptr size). The size in the function name should indicate the amount of data being compared. Also split out the 'Condition' enum into 'RelationalCondition' and 'ResultCondition'. The former is used in binary comparison, the latter compares the latter is a unary condition check on the result of an operation.
Created attachment 90282 [details] The patch
Comment on attachment 90282 [details] The patch rs=me
Fixed in r84399
http://trac.webkit.org/changeset/84399 might have broken Qt Linux ARMv7 Release
Hello, The patch caused a build problem for SH4 platforms. I created a patch to fix the issue. Should I submit a patch here or create a new bug? Regards, Thouraya.
Created attachment 90713 [details] fix issues Hello, Attached a patch to fix the issue. Regards, Thouraya.
Comment on attachment 90713 [details] fix issues Looks great!
Hello, I have a question: the patch can be landed even if the bug is not opened? Regards, Thouraya.
The bug needs to be open for the commit-queue to see the patch.
Comment on attachment 90713 [details] fix issues Clearing flags on attachment: 90713 Committed r84796: <http://trac.webkit.org/changeset/84796>