Bug 58946 – Serve all pending requests when HTTP pipelining is enabled

• Status: NEW
• Component: Page Loading

[David Kilzer (:ddkilzer)]

Created attachment 90276 [details]
Patch

Reviewed by NOBODY (OOPS!).

* loader/ResourceLoadScheduler.cpp:
(WebCore::ResourceLoadScheduler::scheduleLoad): Serve all
pending requests at all priorities when HTTP pipelining is
enabled.
---
 2 files changed, 19 insertions(+), 0 deletions(-)

[WebKit Review Bot]

Attachment 90276 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[David Kilzer (:ddkilzer)]

Comment on attachment 90276 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90276&action=review

> Source/WebCore/loader/ResourceLoadScheduler.cpp:121
> +#if PLATFORM(MAC)

Will change this line to match ResourceRequestMac.mm:

+#if PLATFORM(MAC) && !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)

[Nate Chapin]

Comment on attachment 90276 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90276&action=review

> Source/WebCore/ChangeLog:3
> +        <http://webkit.org/b/00000> Serve all pending requests when HTTP pipelining is enabled

Please update the bug # before submitting.

> Source/WebCore/loader/ResourceLoadScheduler.cpp:124
> +        servePendingRequests(host, ResourceLoadPriorityVeryLow);

Nit: this should probably be ResourceLoadPriorityLowest.

[David Kilzer (:ddkilzer)]

Still doing some investigation to see whether this is actually needed.  Will either land or close as NTBF once that is done.

[David Kilzer (:ddkilzer)]

Antti is looking into this now.