Bug 58939 - Removed a use of markDOMObjectWrapper: NodeLists
Summary: Removed a use of markDOMObjectWrapper: NodeLists
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-19 16:21 PDT by Geoffrey Garen
Modified: 2011-04-19 18:16 PDT (History)
6 users (show)

See Also:

Attachments
Patch (8.93 KB, patch)
2011-04-19 16:25 PDT, Geoffrey Garen 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2011-04-19 16:21:58 PDT 
Removed a use of markDOMObjectWrapper: NodeLists
Comment 1 Geoffrey Garen 2011-04-19 16:25:14 PDT 
Created attachment 90274 [details]
Patch
Comment 2 Oliver Hunt 2011-04-19 16:28:29 PDT 
Comment on attachment 90274 [details]
Patch

r=me, i'm not liking the repeated CustomToJS stuff though.
Comment 3 Geoffrey Garen 2011-04-19 16:30:06 PDT 
> r=me, i'm not liking the repeated CustomToJS stuff though.

It's fixable, but we'd have to move a bunch of code to an XXXCustom.h file. Moving toJS to the XXXCustom.cpp file seemed like the easier way.
Comment 4 Geoffrey Garen 2011-04-19 16:32:44 PDT 
Committed r84309: <http://trac.webkit.org/changeset/84309>
Comment 5 Geoffrey Garen 2011-04-19 16:34:43 PDT 
(In reply to comment #3)
Actually, another way to fix it would be to add a new "CustomOwner" feature -- that would allow us to avoid CustomToJS while still keeping everything custom in XXXCustom.cpp.
Comment 6 WebKit Review Bot 2011-04-19 16:51:09 PDT 
http://trac.webkit.org/changeset/84309 might have broken Chromium Linux Release
Comment 7 WebKit Review Bot 2011-04-19 17:05:14 PDT 
Attachment 90274 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8470495
Comment 8 WebKit Review Bot 2011-04-19 18:16:26 PDT 
Attachment 90274 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8469538