Bug 58933 - [chromium] Clamp dirty regions on content layers to layer bounds
Summary: [chromium] Clamp dirty regions on content layers to layer bounds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Adrienne Walker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-19 15:26 PDT by Adrienne Walker
Modified: 2011-04-21 16:08 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.68 KB, patch)
2011-04-19 15:30 PDT, Adrienne Walker 		jamesr: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrienne Walker 2011-04-19 15:26:58 PDT 
[chromium] Clamp dirty regions on content layers to layer bounds
Comment 1 Adrienne Walker 2011-04-19 15:30:08 PDT 
Created attachment 90266 [details]
Patch
Comment 2 Adrienne Walker 2011-04-19 15:31:26 PDT 
This is the WebKit fix for http://crbug.com/79749.
Comment 3 Vangelis Kokkevis 2011-04-19 16:33:10 PDT 
Comment on attachment 90266 [details]
Patch

unofficial r+ although it probably needs a test too...
Comment 4 James Robinson 2011-04-19 16:36:03 PDT 
Comment on attachment 90266 [details]
Patch

Agree re: test.  We're likely to be mucking about with this code a good bit over the next few weeks and I don't want to rewrite the same bug again without a test.
Comment 5 Adrienne Walker 2011-04-21 11:24:41 PDT 
Because this manually fixes both the original bug and another test case that Vangelis found, I'm going to commit this but leave the bug open until I write a test case.
Comment 6 Stephen White 2011-04-21 11:33:38 PDT 
(In reply to comment #5)
> Because this manually fixes both the original bug and another test case that Vangelis found, I'm going to commit this but leave the bug open until I write a test case.

Sounds good to me (unofficially).  Thanks very much for the quick fix!
Comment 7 Adrienne Walker 2011-04-21 11:39:29 PDT 
Committed r84529: <http://trac.webkit.org/changeset/84529>
Comment 8 Adrienne Walker 2011-04-21 16:08:57 PDT 
Good news, everybody! We already had three test cases that demonstrated this bug.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=media%2Fcontrols-styling.html%2Cmedia%2Fvideo-volume-slider.html%2Cmedia%2Fvideo-zoom-controls.html&group=%40ToT%20GPU%20Mesa%20-%20chromium.org

...they were just all marked as IMAGE fail.