RESOLVED FIXED 58933
[chromium] Clamp dirty regions on content layers to layer bounds 
https://bugs.webkit.org/show_bug.cgi?id=58933
Summary [chromium] Clamp dirty regions on content layers to layer bounds
Adrienne Walker
Reported 2011-04-19 15:26:58 PDT
[chromium] Clamp dirty regions on content layers to layer bounds
Attachments
Patch (1.68 KB, patch)
2011-04-19 15:30 PDT, Adrienne Walker 		jamesr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrienne Walker
Comment 1 2011-04-19 15:30:08 PDT
Created attachment 90266 [details] Patch
Adrienne Walker
Comment 2 2011-04-19 15:31:26 PDT
This is the WebKit fix for http://crbug.com/79749.
Vangelis Kokkevis
Comment 3 2011-04-19 16:33:10 PDT
Comment on attachment 90266 [details] Patch unofficial r+ although it probably needs a test too...
James Robinson
Comment 4 2011-04-19 16:36:03 PDT
Comment on attachment 90266 [details] Patch Agree re: test. We're likely to be mucking about with this code a good bit over the next few weeks and I don't want to rewrite the same bug again without a test.
Adrienne Walker
Comment 5 2011-04-21 11:24:41 PDT
Because this manually fixes both the original bug and another test case that Vangelis found, I'm going to commit this but leave the bug open until I write a test case.
Stephen White
Comment 6 2011-04-21 11:33:38 PDT
(In reply to comment #5) > Because this manually fixes both the original bug and another test case that Vangelis found, I'm going to commit this but leave the bug open until I write a test case. Sounds good to me (unofficially). Thanks very much for the quick fix!
Adrienne Walker
Comment 7 2011-04-21 11:39:29 PDT
Committed r84529: <http://trac.webkit.org/changeset/84529>
Adrienne Walker
Comment 8 2011-04-21 16:08:57 PDT
Good news, everybody! We already had three test cases that demonstrated this bug. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=media%2Fcontrols-styling.html%2Cmedia%2Fvideo-volume-slider.html%2Cmedia%2Fvideo-zoom-controls.html&group=%40ToT%20GPU%20Mesa%20-%20chromium.org ...they were just all marked as IMAGE fail.
Note You need to log in before you can comment on or make changes to this bug.