Bug 58931 - don't show missing text results for tests that only dump image results
Summary: don't show missing text results for tests that only dump image results
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-19 15:16 PDT by Ojan Vafai
Modified: 2011-04-19 16:43 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.00 KB, patch)
2011-04-19 15:17 PDT, Ojan Vafai
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2011-04-19 15:16:15 PDT
don't show missing text results for tests that only dump image results
Comment 1 Ojan Vafai 2011-04-19 15:17:24 PDT
Created attachment 90263 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-04-19 15:28:35 PDT
Comment on attachment 90263 [details]
Patch

I didn't know we had tests which only dumped images?
Comment 3 Dirk Pranke 2011-04-19 15:33:06 PDT
It is possible for any given test to be missing either text, audio, or images (but it should always produce either text or audio). It should not be possible for a test to only produce image data.
Comment 4 Ojan Vafai 2011-04-19 15:38:40 PDT
Oh, I'm wrong. It looks like if the text result passes and the image result is missing, we'll only dump the image result.
Comment 5 Dirk Pranke 2011-04-19 16:20:27 PDT
to further clarify, even though a test will always produce either text or audio, it will only save the output into the layout-test-results directory if the output didn't match the expected content. Ojan's patch is concerned with the saved output (the -actual.* files), not the produced output that lives in memory.

Patch LGTM as well.
Comment 6 Ojan Vafai 2011-04-19 16:43:13 PDT
Committed r84313: <http://trac.webkit.org/changeset/84313>