Bug 58929 - don't show failures table if there are only new tests
Summary: don't show failures table if there are only new tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-19 15:01 PDT by Ojan Vafai
Modified: 2011-04-19 16:38 PDT (History)
2 users (show)

See Also:

Attachments
Patch (11.45 KB, patch)
2011-04-19 15:02 PDT, Ojan Vafai 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2011-04-19 15:01:56 PDT 
don't show failures table if there are only new tests
Comment 1 Ojan Vafai 2011-04-19 15:02:41 PDT 
Created attachment 90261 [details]
Patch
Comment 2 Ojan Vafai 2011-04-19 15:03:24 PDT 
Sorry for the large diff. It's almost entirely just moving code around.
Comment 3 Eric Seidel (no email) 2011-04-19 15:29:43 PDT 
Comment on attachment 90261 [details]
Patch

OK.  Seems all your globals probably want to be instance members on some class instead (with one global instance of the class).
Comment 4 Ojan Vafai 2011-04-19 15:36:40 PDT 
(In reply to comment #3)
> (From update of attachment 90261 [details])
> OK.  Seems all your globals probably want to be instance members on some class instead (with one global instance of the class).

Totally. I'll do that in a separate patch.
Comment 5 Ojan Vafai 2011-04-19 16:38:55 PDT 
Committed r84312: <http://trac.webkit.org/changeset/84312>