WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
58929
don't show failures table if there are only new tests
https://bugs.webkit.org/show_bug.cgi?id=58929
Summary
don't show failures table if there are only new tests
Ojan Vafai
Reported
2011-04-19 15:01:56 PDT
don't show failures table if there are only new tests
Attachments
Patch
(11.45 KB, patch)
2011-04-19 15:02 PDT
,
Ojan Vafai
eric
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ojan Vafai
Comment 1
2011-04-19 15:02:41 PDT
Created
attachment 90261
[details]
Patch
Ojan Vafai
Comment 2
2011-04-19 15:03:24 PDT
Sorry for the large diff. It's almost entirely just moving code around.
Eric Seidel (no email)
Comment 3
2011-04-19 15:29:43 PDT
Comment on
attachment 90261
[details]
Patch OK. Seems all your globals probably want to be instance members on some class instead (with one global instance of the class).
Ojan Vafai
Comment 4
2011-04-19 15:36:40 PDT
(In reply to
comment #3
)
> (From update of
attachment 90261
[details]
) > OK. Seems all your globals probably want to be instance members on some class instead (with one global instance of the class).
Totally. I'll do that in a separate patch.
Ojan Vafai
Comment 5
2011-04-19 16:38:55 PDT
Committed
r84312
: <
http://trac.webkit.org/changeset/84312
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug