Bug 58927 - Move and rename GLES2Canvas
Summary: Move and rename GLES2Canvas
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Stephen White
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-19 14:11 PDT by Stephen White
Modified: 2011-04-20 08:02 PDT (History)
2 users (show)

See Also:

Attachments
Patch (105.00 KB, patch)
2011-04-19 14:26 PDT, Stephen White 		kbr: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen White 2011-04-19 14:11:28 PDT 
GLES2Canvas isn't really a canvas; it's a context.  It also has no particular ties to platform/graphics/chromium, and should live in platform/graphics/gpu where all the shaders are.
Comment 1 Stephen White 2011-04-19 14:26:38 PDT 
Created attachment 90254 [details]
Patch
Comment 2 Kenneth Russell 2011-04-19 15:48:31 PDT 
Comment on attachment 90254 [details]
Patch

This looks fine to me. Usually this sort of renaming is done with Tools/Scripts/do-webcore-rename, but I don't think that script supports moving files between subdirectories. It's clear that this patch contains only the straightforward renaming.
Comment 3 Stephen White 2011-04-19 17:46:49 PDT 
(In reply to comment #2)
> (From update of attachment 90254 [details])
> This looks fine to me. Usually this sort of renaming is done with Tools/Scripts/do-webcore-rename, but I don't think that script supports moving files between subdirectories. It's clear that this patch contains only the straightforward renaming.

Thanks!  I didn't know about that script.
Comment 4 Stephen White 2011-04-20 08:02:33 PDT 
Committed r84374: <http://trac.webkit.org/changeset/84374>