Bug 58919 - WebKit2: Merge SelectionState and TextInputState
Summary: WebKit2: Merge SelectionState and TextInputState
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.6
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-19 12:45 PDT by Alexey Proskuryakov
Modified: 2011-04-19 15:54 PDT (History)
1 user (show)

See Also:

Attachments
proposed patch (66.88 KB, patch)
2011-04-19 12:50 PDT, Alexey Proskuryakov 		adele: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2011-04-19 12:45:55 PDT 
These are almost the same. SelectionState is only updated asynchronously, while TextInputState is updated synchronously, and is only valid while a key event is being processed.

That's confusing. We can always keep the latest known state in the one place.
Comment 1 Alexey Proskuryakov 2011-04-19 12:50:25 PDT 
Created attachment 90239 [details]
proposed patch
Comment 2 Enrica Casucci 2011-04-19 13:41:52 PDT 
Comment on attachment 90239 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90239&action=review

The patch looks good to me. I like the way the code gets simplified. I don't understand why EditorState.h appears twice looking at the review, but it is probably a bug in the review tool. The only comment I have is the copyright year.
Also, it appears there are problems in applying the patch for the qt build.

> Source/WebKit2/Shared/EditorState.h:3
> + *

Copyright 2011.
Comment 3 Alexey Proskuryakov 2011-04-19 15:54:13 PDT 
Committed <http://trac.webkit.org/changeset/84304>.