Bug 58906 - GLES2Canvas state application should be refactored
Summary: GLES2Canvas state application should be refactored
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Minor
Assignee: Stephen White
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-19 11:06 PDT by Stephen White
Modified: 2011-04-19 12:04 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.03 KB, patch)
2011-04-19 11:08 PDT, Stephen White 		kbr: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen White 2011-04-19 11:06:33 PDT 
There are a number of places where we bind the main framebuffer, apply compositing and clipping state.  This should be refactored.
Comment 1 Stephen White 2011-04-19 11:08:26 PDT 
Created attachment 90218 [details]
Patch
Comment 2 Kenneth Russell 2011-04-19 12:02:17 PDT 
Comment on attachment 90218 [details]
Patch

Looks good to me.
Comment 3 Stephen White 2011-04-19 12:04:18 PDT 
Committed r84277: <http://trac.webkit.org/changeset/84277>