Bug 58887 - [Qt] Add possibility to run and set URLLoader from the browsers
Summary: [Qt] Add possibility to run and set URLLoader from the browsers
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Zoltan Horvath
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-19 06:04 PDT by Zoltan Horvath
Modified: 2014-02-03 03:17 PST (History)
2 users (show)

See Also:


Attachments
proposed patch (33.10 KB, patch)
2011-04-19 06:05 PDT, Zoltan Horvath
zoltan: commit-queue-
Details | Formatted Diff | Diff
updated to TOT (32.33 KB, patch)
2011-10-10 07:49 PDT, Zoltan Horvath
kling: review-
webkit-ews: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2011-04-19 06:04:31 PDT
Add an URLLoader widget to make it possible to run and set URLLoader from the browsers.
Fix command line URL parameter handling in case of -robot-timeout and -robot-extra-time.
Comment 1 Zoltan Horvath 2011-04-19 06:05:53 PDT
Created attachment 90187 [details]
proposed patch
Comment 2 WebKit Review Bot 2011-04-19 06:07:46 PDT
Attachment 90187 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/MiniBrowser/qt/B..." exit_code: 1

Tools/QtTestBrowser/launcherwindow.h:66:  Alphabetical sorting problem.  [build/include_order] [4]
Tools/QtTestBrowser/UrlLoaderWidget.cpp:28:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 2 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Zoltan Horvath 2011-04-19 06:15:37 PDT
Comment on attachment 90187 [details]
proposed patch

I will fix style issues before land.
Comment 4 Andreas Kling 2011-04-26 16:57:46 PDT
Comment on attachment 90187 [details]
proposed patch

This seems really unnecessary, would anyone really use it? (Given that it's available on the command-line already.)
r- because I don't see the usecase. Feel free to explain it and reset r?
Comment 5 Andras Becsi 2011-04-27 07:06:35 PDT
(In reply to comment #4)
> (From update of attachment 90187 [details])
> This seems really unnecessary, would anyone really use it? (Given that it's available on the command-line already.)
> r- because I don't see the usecase. Feel free to explain it and reset r?

I already use this patch for collecting profile data.

My workflow is browsing various sites, then loading a list of selected pages with the URLLoader, then browsing again and loading another list, all this without losing the caches in between.

I think this is kind of a use-case for this feature so I would appreciate it.
Comment 6 Zoltan Horvath 2011-10-10 07:49:05 PDT
Created attachment 110359 [details]
updated to TOT

mwenge also told me on IRC this patch is useful, so I updated it.
Comment 7 Early Warning System Bot 2011-10-10 07:57:51 PDT
Comment on attachment 110359 [details]
updated to TOT

Attachment 110359 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10009952
Comment 8 Andreas Kling 2011-10-26 04:31:12 PDT
Comment on attachment 110359 [details]
updated to TOT

Since MiniBrowser is being rewritten in QML, this needs updating. :)
Comment 9 Jocelyn Turcotte 2014-02-03 03:17:34 PST
=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.