Bug 58860 – make results file work with audio and reftests

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ojan Vafai]

make results file work with audio and reftests

[Ojan Vafai]

Created attachment 90132 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 90132 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90132&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/json_results.html:154
> +    // FIXME: use audio tags for AUDIO tests?

woh, that'd be cool.

> Tools/Scripts/webkitpy/layout_tests/layout_package/json_results.html:264
> +      row += resultLink(test_prefix, '-expected.wav', 'expected');
> +      row += resultLink(test_prefix, '-actual.wav', 'actual');

Are they always .wav files?

> Tools/Scripts/webkitpy/layout_tests/layout_package/json_results.html:292
> +              resultLink(test_prefix, '-actual.png', 'actual') +

You repeat these suffixes a lot.  Maybe we should use constants?

[Dirk Pranke]

(In reply to comment #2)
> (From update of attachment 90132 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=90132&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/layout_package/json_results.html:154
> > +    // FIXME: use audio tags for AUDIO tests?
> 
> woh, that'd be cool.
> 

Per crogers, that probably wouldn't be that useful, since you normally want to load them into an audio editor/analyzer to figure out why they're different.

> > Tools/Scripts/webkitpy/layout_tests/layout_package/json_results.html:264
> > +      row += resultLink(test_prefix, '-expected.wav', 'expected');
> > +      row += resultLink(test_prefix, '-actual.wav', 'actual');
> 
> Are they always .wav files?

Yes.

[Ojan Vafai]

Committed r84267: <http://trac.webkit.org/changeset/84267>

[WebKit Review Bot]

http://trac.webkit.org/changeset/84267 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing:
plugins/mouse-click-iframe-to-plugin.html