Bug 58860 - make results file work with audio and reftests
Summary: make results file work with audio and reftests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-18 19:11 PDT by Ojan Vafai
Modified: 2011-04-19 12:40 PDT (History)
6 users (show)

See Also:


Attachments
Patch (6.72 KB, patch)
2011-04-18 19:12 PDT, Ojan Vafai
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2011-04-18 19:11:13 PDT
make results file work with audio and reftests
Comment 1 Ojan Vafai 2011-04-18 19:12:16 PDT
Created attachment 90132 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-04-18 19:14:28 PDT
Comment on attachment 90132 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90132&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/json_results.html:154
> +    // FIXME: use audio tags for AUDIO tests?

woh, that'd be cool.

> Tools/Scripts/webkitpy/layout_tests/layout_package/json_results.html:264
> +      row += resultLink(test_prefix, '-expected.wav', 'expected');
> +      row += resultLink(test_prefix, '-actual.wav', 'actual');

Are they always .wav files?

> Tools/Scripts/webkitpy/layout_tests/layout_package/json_results.html:292
> +              resultLink(test_prefix, '-actual.png', 'actual') +

You repeat these suffixes a lot.  Maybe we should use constants?
Comment 3 Dirk Pranke 2011-04-18 19:33:52 PDT
(In reply to comment #2)
> (From update of attachment 90132 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=90132&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/layout_package/json_results.html:154
> > +    // FIXME: use audio tags for AUDIO tests?
> 
> woh, that'd be cool.
> 

Per crogers, that probably wouldn't be that useful, since you normally want to load them into an audio editor/analyzer to figure out why they're different.

> > Tools/Scripts/webkitpy/layout_tests/layout_package/json_results.html:264
> > +      row += resultLink(test_prefix, '-expected.wav', 'expected');
> > +      row += resultLink(test_prefix, '-actual.wav', 'actual');
> 
> Are they always .wav files?

Yes.
Comment 4 Ojan Vafai 2011-04-19 11:12:26 PDT
Committed r84267: <http://trac.webkit.org/changeset/84267>
Comment 5 WebKit Review Bot 2011-04-19 12:40:34 PDT
http://trac.webkit.org/changeset/84267 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing:
plugins/mouse-click-iframe-to-plugin.html