Bug 58854 - LayoutTest demonstrating that filesystem: URLs are not cached in WebKit
Summary: LayoutTest demonstrating that filesystem: URLs are not cached in WebKit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Klein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-18 17:37 PDT by Adam Klein
Modified: 2011-05-10 16:28 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.31 KB, patch)
2011-04-18 17:38 PDT, Adam Klein 		no flags Details | Formatted Diff | Diff
Patch (3.32 KB, patch)
2011-05-03 10:15 PDT, Adam Klein 		no flags Details | Formatted Diff | Diff
Patch (3.30 KB, patch)
2011-05-04 12:21 PDT, Adam Klein 		levin: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Klein 2011-04-18 17:37:28 PDT 
LayoutTest demonstrating that filesystem: URLs are not cached in WebKit
Comment 1 Adam Klein 2011-04-18 17:38:20 PDT 
Created attachment 90122 [details]
Patch
Comment 2 Adam Klein 2011-05-03 10:15:11 PDT 
Created attachment 92086 [details]
Patch
Comment 3 David Levin 2011-05-03 10:18:46 PDT 
I'd like Kinuko to do a first pass on this.
Comment 4 Kinuko Yasuda 2011-05-04 12:06:46 PDT 
Comment on attachment 92086 [details]
Patch

The test code looks good to me.

View in context: https://bugs.webkit.org/attachment.cgi?id=92086&action=review

> LayoutTests/http/tests/filesystem/no-cache-filesystem-url.html:29
> +                + rand + ') ? "SUCCESS" : "FAILURE";');

style nit: no need to wrap line
Comment 5 Adam Klein 2011-05-04 12:21:38 PDT 
Created attachment 92298 [details]
Patch
Comment 6 Adam Klein 2011-05-04 12:21:59 PDT 
Comment on attachment 92086 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92086&action=review

>> LayoutTests/http/tests/filesystem/no-cache-filesystem-url.html:29
>> +                + rand + ') ? "SUCCESS" : "FAILURE";');
> 
> style nit: no need to wrap line

Fixed.
Comment 7 Adam Klein 2011-05-10 16:28:45 PDT 
Committed r86192: <http://trac.webkit.org/changeset/86192>