RESOLVED FIXED 58848
[Qt] REGRESSION(84057): It made 4 API tests fail 
https://bugs.webkit.org/show_bug.cgi?id=58848
Summary [Qt] REGRESSION(84057): It made 4 API tests fail
Csaba Osztrogonác
Reported 2011-04-18 16:08:03 PDT
FAIL! : tst_QWebPage::backActionUpdate() Compared values are not the same Actual (loadSpy.count()): 1 Expected (2): 2 Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(1453)] FAIL! : tst_QWebPage::errorPageExtensionInFrameset() Received a fatal error. Loc: [Unknown file(0)] FAIL! : tst_QWebFrame::horizontalScrollAfterBack() '(frame->scrollBarGeometry(Qt::Horizontal)).height()' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp(3152)] FAIL! : tst_QWebFrame::requestedUrl() Compared values are not the same Actual (spy.count()): 2 Expected (3): 3 Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp(2404)]
Attachments
patch (5.24 KB, patch)
2011-04-20 23:21 PDT, Caio Marcelo de Oliveira Filho 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2011-04-18 16:10:16 PDT
Hey men, you should have checked the buildbot after landing a patch. :-/
Caio Marcelo de Oliveira Filho
Comment 2 2011-04-20 23:21:52 PDT
Created attachment 90499 [details] patch This patch should fix 3 tests failing. The requestedUrl() one is handled by bug 59070.
Csaba Osztrogonác
Comment 3 2011-04-20 23:36:58 PDT
Comment on attachment 90499 [details] patch LGTM, r=me
WebKit Commit Bot
Comment 4 2011-04-21 00:29:51 PDT
Comment on attachment 90499 [details] patch Clearing flags on attachment: 90499 Committed r84475: <http://trac.webkit.org/changeset/84475>
WebKit Commit Bot
Comment 5 2011-04-21 00:29:56 PDT
All reviewed patches have been landed. Closing bug.
Caio Marcelo de Oliveira Filho
Comment 6 2011-04-21 00:35:25 PDT
Reopening since there is still a dependency bug opened to fix the remaining test case.
Note You need to log in before you can comment on or make changes to this bug.