WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 58846
Re-add a null check lost in
r83081
https://bugs.webkit.org/show_bug.cgi?id=58846
Summary
Re-add a null check lost in r83081
Alexey Proskuryakov
Reported
2011-04-18 15:49:32 PDT
A null check was lost in selectedRange(), causing crashes.
Attachments
proposed patch
(1.34 KB, patch)
2011-04-18 15:51 PDT
,
Alexey Proskuryakov
mjs
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2011-04-18 15:51:51 PDT
Created
attachment 90109
[details]
proposed patch
Robert Sesek
Comment 2
2011-04-18 15:55:38 PDT
An alternative would be to return false in TextIterator::locationAndLengthFromRange(), which is what WebPage::getLocationAndLengthFromRange used to do. Sorry that I introduced so many regressions :/
Maciej Stachowiak
Comment 3
2011-04-18 15:58:07 PDT
Comment on
attachment 90109
[details]
proposed patch r=me
Alexey Proskuryakov
Comment 4
2011-04-18 16:07:57 PDT
Committed <
http://trac.webkit.org/changeset/84202
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug