Bug 58846 - Re-add a null check lost in r83081
Summary: Re-add a null check lost in r83081
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.6
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-18 15:49 PDT by Alexey Proskuryakov
Modified: 2011-04-18 16:07 PDT (History)
1 user (show)

See Also:


Attachments
proposed patch (1.34 KB, patch)
2011-04-18 15:51 PDT, Alexey Proskuryakov
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2011-04-18 15:49:32 PDT
A null check was lost in selectedRange(), causing crashes.
Comment 1 Alexey Proskuryakov 2011-04-18 15:51:51 PDT
Created attachment 90109 [details]
proposed patch
Comment 2 Robert Sesek 2011-04-18 15:55:38 PDT
An alternative would be to return false in TextIterator::locationAndLengthFromRange(), which is what WebPage::getLocationAndLengthFromRange used to do.

Sorry that I introduced so many regressions :/
Comment 3 Maciej Stachowiak 2011-04-18 15:58:07 PDT
Comment on attachment 90109 [details]
proposed patch

r=me
Comment 4 Alexey Proskuryakov 2011-04-18 16:07:57 PDT
Committed <http://trac.webkit.org/changeset/84202>.