Bug 58822 - 100% reproducible crash when right-clicking any element in Web Inspector on any page
Summary: 100% reproducible crash when right-clicking any element in Web Inspector on a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.6
: P1 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-04-18 13:47 PDT by Alexey Proskuryakov
Modified: 2011-04-19 15:35 PDT (History)
4 users (show)

See Also:

Attachments
proposed fix (64.79 KB, patch)
2011-04-18 13:57 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
with build fixes (68.68 KB, patch)
2011-04-18 16:06 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
proposed fix (2.18 KB, patch)
2011-04-19 14:13 PDT, Alexey Proskuryakov 		timothy: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2011-04-18 13:47:47 PDT 
Steps to reproduce:

1. Go to http://webkit.org
2. Open the web inspector
3. Scroll to the top of the inspector so you can see this page's <html> element. Don't click on it.
4. Right click and choose Add Attribute.

<rdar://problem/9279698>
Comment 1 Alexey Proskuryakov 2011-04-18 13:57:49 PDT 
Created attachment 90087 [details]
proposed fix
Comment 2 WebKit Review Bot 2011-04-18 15:05:07 PDT 
Attachment 90087 [details] did not build on mac:
Build output: http://queues.webkit.org/results/8474043
Comment 3 Build Bot 2011-04-18 15:53:07 PDT 
Attachment 90087 [details] did not build on win:
Build output: http://queues.webkit.org/results/8475045
Comment 4 Alexey Proskuryakov 2011-04-18 16:06:27 PDT 
Created attachment 90111 [details]
with build fixes
Comment 5 Alexey Proskuryakov 2011-04-19 12:46:40 PDT 
Comment on attachment 90111 [details]
with build fixes

I want to fix this differently, and also to split refactoring into a separate patch.
Comment 6 Alexey Proskuryakov 2011-04-19 14:13:50 PDT 
Created attachment 90251 [details]
proposed fix
Comment 7 Alexey Proskuryakov 2011-04-19 14:37:33 PDT 
Committed <http://trac.webkit.org/changeset/84297>.
Comment 8 WebKit Review Bot 2011-04-19 15:35:49 PDT 
http://trac.webkit.org/changeset/84297 might have broken Qt Linux Release