Bug 58821 - Don't cast BitmapImageSingleFrameSkia to BitmapImage
Summary: Don't cast BitmapImageSingleFrameSkia to BitmapImage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: John Bauman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-18 13:35 PDT by John Bauman
Modified: 2011-08-03 10:15 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.70 KB, patch)
2011-04-18 13:50 PDT, John Bauman 		no flags Details | Formatted Diff | Diff
Patch (2.72 KB, patch)
2011-04-18 14:01 PDT, John Bauman 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Bauman 2011-04-18 13:35:28 PDT 
Don't cast BitmapImageSingleFrameSkia to BitmapImage
Comment 1 John Bauman 2011-04-18 13:50:49 PDT 
Created attachment 90084 [details]
Patch
Comment 3 WebKit Review Bot 2011-04-18 13:55:35 PDT 
Attachment 90084 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 3 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 John Bauman 2011-04-18 14:01:34 PDT 
Created attachment 90090 [details]
Patch
Comment 5 Kenneth Russell 2011-04-18 15:18:15 PDT 
Comment on attachment 90090 [details]
Patch

How was the logic error discovered? Would it be possible to add a WebGL layout test to cover this case?
Comment 6 John Bauman 2011-04-18 15:27:11 PDT 
Some of the webgl layout tests started crashing due to this bug, after an unrelated change to BitmapImageSingleFrameSkia caused the problem to become visible. I can't really think of a type of test that would deterministically catch this bug.
Comment 7 Kenneth Russell 2011-04-18 15:40:43 PDT 
Comment on attachment 90090 [details]
Patch

OK. Let's get this fix in ASAP.
Comment 8 WebKit Commit Bot 2011-04-18 18:35:31 PDT 
Comment on attachment 90090 [details]
Patch

Clearing flags on attachment: 90090

Committed r84213: <http://trac.webkit.org/changeset/84213>
Comment 9 WebKit Commit Bot 2011-04-18 18:35:36 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Tom Hudson 2011-08-03 10:15:35 PDT 
Similar problems cropping up in https://bugs.webkit.org/show_bug.cgi?id=65063 because the underlying issue - casting to BitmapImage - isn't limited to this one case.