Don't cast BitmapImageSingleFrameSkia to BitmapImage
Created attachment 90084 [details] Patch
See http://code.google.com/p/chromium/issues/detail?id=79739
Attachment 90084 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 90090 [details] Patch
Comment on attachment 90090 [details] Patch How was the logic error discovered? Would it be possible to add a WebGL layout test to cover this case?
Some of the webgl layout tests started crashing due to this bug, after an unrelated change to BitmapImageSingleFrameSkia caused the problem to become visible. I can't really think of a type of test that would deterministically catch this bug.
Comment on attachment 90090 [details] Patch OK. Let's get this fix in ASAP.
Comment on attachment 90090 [details] Patch Clearing flags on attachment: 90090 Committed r84213: <http://trac.webkit.org/changeset/84213>
All reviewed patches have been landed. Closing bug.
Similar problems cropping up in https://bugs.webkit.org/show_bug.cgi?id=65063 because the underlying issue - casting to BitmapImage - isn't limited to this one case.