Bug 58820 - [Qt] QtInstance method cache ownership rules are unclear
Summary: [Qt] QtInstance method cache ownership rules are unclear
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-18 13:31 PDT by Oliver Hunt
Modified: 2011-04-19 13:41 PDT (History)
2 users (show)

See Also:


Attachments
Patch (5.22 KB, patch)
2011-04-19 11:45 PDT, Oliver Hunt
no flags Details | Formatted Diff | Diff
Patch (4.34 KB, patch)
2011-04-19 12:38 PDT, Oliver Hunt
no flags Details | Formatted Diff | Diff
same as earlier, with build fix (4.43 KB, patch)
2011-04-19 13:24 PDT, Oliver Hunt
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2011-04-18 13:31:41 PDT
I've temporarily made a cache use Global<> however it may be possible to make that produce ref cycles.

I'm also unsure how correct the method cache is -- if more than one JS object uses the same backing instance the two objects may share function instances.  I don't know if this is possible, or even desired, just recording the observation.
Comment 1 Oliver Hunt 2011-04-19 11:45:36 PDT
Created attachment 90230 [details]
Patch
Comment 2 Early Warning System Bot 2011-04-19 11:52:03 PDT
Attachment 90230 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8475357
Comment 3 Oliver Hunt 2011-04-19 12:38:34 PDT
Created attachment 90238 [details]
Patch
Comment 4 Early Warning System Bot 2011-04-19 12:49:25 PDT
Attachment 90238 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8475377
Comment 5 Oliver Hunt 2011-04-19 13:24:35 PDT
Created attachment 90244 [details]
same as earlier, with build fix
Comment 6 Andreas Kling 2011-04-19 13:32:39 PDT
Comment on attachment 90244 [details]
same as earlier, with build fix

!em=r
Comment 7 Oliver Hunt 2011-04-19 13:41:21 PDT
Committed r84286: <http://trac.webkit.org/changeset/84286>