RESOLVED FIXED Bug 58820
[Qt] QtInstance method cache ownership rules are unclear 
https://bugs.webkit.org/show_bug.cgi?id=58820
Summary [Qt] QtInstance method cache ownership rules are unclear
Oliver Hunt
Reported 2011-04-18 13:31:41 PDT
I've temporarily made a cache use Global<> however it may be possible to make that produce ref cycles. I'm also unsure how correct the method cache is -- if more than one JS object uses the same backing instance the two objects may share function instances. I don't know if this is possible, or even desired, just recording the observation.
Attachments
Patch (5.22 KB, patch)
2011-04-19 11:45 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (4.34 KB, patch)
2011-04-19 12:38 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
same as earlier, with build fix (4.43 KB, patch)
2011-04-19 13:24 PDT, Oliver Hunt 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2011-04-19 11:45:36 PDT
Created attachment 90230 [details] Patch
Early Warning System Bot
Comment 2 2011-04-19 11:52:03 PDT
Attachment 90230 [details] did not build on qt: Build output: http://queues.webkit.org/results/8475357
Oliver Hunt
Comment 3 2011-04-19 12:38:34 PDT
Created attachment 90238 [details] Patch
Early Warning System Bot
Comment 4 2011-04-19 12:49:25 PDT
Attachment 90238 [details] did not build on qt: Build output: http://queues.webkit.org/results/8475377
Oliver Hunt
Comment 5 2011-04-19 13:24:35 PDT
Created attachment 90244 [details] same as earlier, with build fix
Andreas Kling
Comment 6 2011-04-19 13:32:39 PDT
Comment on attachment 90244 [details] same as earlier, with build fix !em=r
Oliver Hunt
Comment 7 2011-04-19 13:41:21 PDT
Committed r84286: <http://trac.webkit.org/changeset/84286>
Note You need to log in before you can comment on or make changes to this bug.