Bug 58798 - WebKit needs to stop importing <AppKit/NSTextChecker.h>
Summary: WebKit needs to stop importing <AppKit/NSTextChecker.h>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh Intel OS X 10.6
: P2 Normal
Assignee: Jia Pu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-04-18 11:03 PDT by Jia Pu
Modified: 2011-04-18 20:50 PDT (History)
4 users (show)

See Also:


Attachments
Patch (v1) (18.13 KB, patch)
2011-04-18 11:13 PDT, Jia Pu
no flags Details | Formatted Diff | Diff
Patch (v2) (17.99 KB, patch)
2011-04-18 13:25 PDT, Jia Pu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jia Pu 2011-04-18 11:03:38 PDT
NSTextChecker.h is private header. We should use the public header NSSpellChecker.h, and the equivalent names and functions defined there.
<rdar://problem/9294938>
Comment 1 Jia Pu 2011-04-18 11:13:14 PDT
Created attachment 90057 [details]
Patch (v1)
Comment 2 Mark Rowe (bdash) 2011-04-18 11:23:07 PDT
Comment on attachment 90057 [details]
Patch (v1)

View in context: https://bugs.webkit.org/attachment.cgi?id=90057&action=review

r=me

> Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm:80
> +- (NSString *)languageForWordRange:(NSRange)range inString:(NSString *)string orthography:(NSOrthography *)orthography;

I think you should drop the comment.  In other places we call the category “AppKitSecretsIKnow”.

> Source/WebKit2/UIProcess/mac/TextCheckerMac.mm:36
> +- (NSString *)languageForWordRange:(NSRange)range inString:(NSString *)string orthography:(NSOrthography *)orthography;

Same as above.
Comment 3 mitz 2011-04-18 11:30:30 PDT
Comment on attachment 90057 [details]
Patch (v1)

View in context: https://bugs.webkit.org/attachment.cgi?id=90057&action=review

>> Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm:80
>> +- (NSString *)languageForWordRange:(NSRange)range inString:(NSString *)string orthography:(NSOrthography *)orthography;
> 
> I think you should drop the comment.  In other places we call the category “AppKitSecretsIKnow”.

That is the old convention. The modern convention is Web<class>Details, so in this case, WebNSSpellCheckerDetails.
Comment 4 Jia Pu 2011-04-18 13:25:58 PDT
Created attachment 90082 [details]
Patch (v2)
Comment 5 WebKit Commit Bot 2011-04-18 20:48:06 PDT
Comment on attachment 90082 [details]
Patch (v2)

Clearing flags on attachment: 90082

Committed r84220: <http://trac.webkit.org/changeset/84220>
Comment 6 WebKit Commit Bot 2011-04-18 20:48:11 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Commit Bot 2011-04-18 20:50:26 PDT
The commit-queue encountered the following flaky tests while processing attachment 90082 [details]:

java/lc3/JSObject/ToObject-001.html bug 53091 (author: ap@webkit.org)
http/tests/xmlhttprequest/cross-origin-no-authorization.html bug 33357 (author: ap@webkit.org)
The commit-queue is continuing to process your patch.