NSTextChecker.h is private header. We should use the public header NSSpellChecker.h, and the equivalent names and functions defined there. <rdar://problem/9294938>
Created attachment 90057 [details] Patch (v1)
Comment on attachment 90057 [details] Patch (v1) View in context: https://bugs.webkit.org/attachment.cgi?id=90057&action=review r=me > Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm:80 > +- (NSString *)languageForWordRange:(NSRange)range inString:(NSString *)string orthography:(NSOrthography *)orthography; I think you should drop the comment. In other places we call the category “AppKitSecretsIKnow”. > Source/WebKit2/UIProcess/mac/TextCheckerMac.mm:36 > +- (NSString *)languageForWordRange:(NSRange)range inString:(NSString *)string orthography:(NSOrthography *)orthography; Same as above.
Comment on attachment 90057 [details] Patch (v1) View in context: https://bugs.webkit.org/attachment.cgi?id=90057&action=review >> Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm:80 >> +- (NSString *)languageForWordRange:(NSRange)range inString:(NSString *)string orthography:(NSOrthography *)orthography; > > I think you should drop the comment. In other places we call the category “AppKitSecretsIKnow”. That is the old convention. The modern convention is Web<class>Details, so in this case, WebNSSpellCheckerDetails.
Created attachment 90082 [details] Patch (v2)
Comment on attachment 90082 [details] Patch (v2) Clearing flags on attachment: 90082 Committed r84220: <http://trac.webkit.org/changeset/84220>
All reviewed patches have been landed. Closing bug.
The commit-queue encountered the following flaky tests while processing attachment 90082 [details]: java/lc3/JSObject/ToObject-001.html bug 53091 (author: ap@webkit.org) http/tests/xmlhttprequest/cross-origin-no-authorization.html bug 33357 (author: ap@webkit.org) The commit-queue is continuing to process your patch.